BruceSherwood / vpython-jupyter

This repository has been moved to https://github.com/vpython/vpython-jupyter
64 stars 33 forks source link

Fix errors in logic of baseObj.__del__ and .delete #105

Closed mwcraig closed 5 years ago

mwcraig commented 5 years ago

For the moment this just cleans up some consistency issues by checking that sender is not None (it is None in the case in the no-notebook code). From what I can tell None was the value it once had.

There is an issue this does not fix (will open an issue for it in the issue tracker so we don't forget): the delete method doesn't actually delete objects from the canvas. I've never needed to use it, so it isn't a high priority, I think.