BruceSherwood / vpython-jupyter

This repository has been moved to https://github.com/vpython/vpython-jupyter
64 stars 33 forks source link

add Cython to requirements.txt to restore MyBinder building #54

Closed fomightez closed 6 years ago

fomightez commented 6 years ago

My fork of this wasn't building after recent updates to Binder/repo2docker. I added Cython to requirements.txt after it was pointed out by @minrk that, "It has a cython requirement to build, but it isn't listed as a dependency." In regards to that he also added, "It's a new behavior of repo2docker to run pip install . if it finds a setup.py. That's probably the relevant change."

mwcraig commented 6 years ago

@fomightez -- thanks for reporting this! The binder badge on our README should work for you now, but please reopen this if it does not.