search

BruceSherwood / vpython-jupyter

This repository has been moved to https://github.com/vpython/vpython-jupyter
64 stars 33 forks source link

Simplify notebook logic #95

Closed mwcraig closed 5 years ago

mwcraig commented 5 years ago

This removes version checks for ipython and ipykernel. I will set a minimum version for IPython in the setup.py to 4 (ipykernel started at version 4 so no need for a minimum version for that).

Fixes #73 (was bug)

Issues below were compatibility checks:

Fixes #74 Fixes #75 Fixes #76 Fixes #77

mwcraig commented 5 years ago

@jcoady — do these changes look ok? I’ve tested with ipykernel 4 and 5, on lab and notebook...

jcoady commented 5 years ago

Matt if you use the websocket in ipykernel 4.x to receive messages from the front end over the websocket instead of the comm channel then you should also make the change in rate_control.py to check ipykernel 4.x instead of ipykernel 5.0.0 . If messages are received over the comm channel then we call kernel.do_one_iteration() method but if they are received over the websocket then we don't need to call kernel.do_one_iteration(). You should test your changes again with the change in rate_control.py to check that everything works properly.

mwcraig commented 5 years ago

Looks like this works with Ipython 6/7 and ipykernel 4/5 (all four combinations of those possibilities) in both jupyter notebook and lab.

mwcraig commented 5 years ago

I'm going to go ahead and merge this....