Brummi / MonoRec

Official implementation of the paper: MonoRec: Semi-Supervised Dense Reconstruction in Dynamic Environments from a Single Moving Camera (CVPR 2021)
MIT License
587 stars 85 forks source link

Usage of "--options" in training command #35

Closed fengziyue closed 2 years ago

fengziyue commented 2 years ago

Hi:

Thank you for the wonderful work, I have a question about the usage of the "--options" in training commands. My understanding is the "--options" are used for the loss functions in "model/loss_functions/monorec_loss.py". but since the monorec_mask.json has defined the loss function as "mask_loss", which does not have the "stereo" option, why do we need to add "--options stereo" to train the mask module? python train_monorec.py --config configs/train/monorec/monorec_mask.json --options stereo

Any clarification is greatly appreciated!

Brummi commented 2 years ago

Hi!

thanks for showing interest in our work. You are right, mask loss doesn't consider the stereo option. The reason it is there is probably because I copy & pasted the options flag to every training. For the mask bootstrap step, it can be removed.

Best, Felix