Brummi / MonoRec

Official implementation of the paper: MonoRec: Semi-Supervised Dense Reconstruction in Dynamic Environments from a Single Moving Camera (CVPR 2021)
MIT License
587 stars 85 forks source link

Why set temporal frames from default 2 to 10 when 'lidar_depth' and 'annotated_lidar' are enabled? #40

Closed ruili3 closed 2 years ago

ruili3 commented 2 years ago

Hi,

Thank you al lot for your impressive work.

I found a place that I do not understand. As shown in the code below https://github.com/Brummi/MonoRec/blob/b2b3decc130d9ca333d1350096b9838a12f977a3/data_loader/kitti_odometry_dataset.py#L56-L58

why set the nearby frames from default 2 to at least 10 when 'lidar_depth' and 'annotated_lidar' are enabled. Is it a general setting for both training and testing or only a setting for testing? Thank you!

Brummi commented 2 years ago

Thank you for showing interest in our work!

If I remember correctly, this is because the annotated lidar is not available for the 5 first and 5 last frames of a sequence. (they are generated by aggregating lidars over multiple timesteps). Therefore, we have to make sure to ignore the first and last 5 frames in the sequence (-> extra frames >= 10, offset >= 5).

Best, Felix

ruili3 commented 2 years ago

Oh I understand, so the number of adjacent frames is not changed (==2), and only the first and last 5 frames are overlooked. Do I understand it correctly?

Best

On Wed, Jul 27, 2022 at 9:40 PM Felix Wimbauer @.***> wrote:

Thank you for showing interest in our work!

If I remember correctly, this is because the annotated lidar is not available for the 5 first and 5 last frames of a sequence. (they are generated by aggregating lidars over multiple timesteps). Therefore, we have to make sure to ignore the first and last 5 frames in the sequence (-> extra frames >= 10, offset >= 5).

Best, Felix

— Reply to this email directly, view it on GitHub https://github.com/Brummi/MonoRec/issues/40#issuecomment-1196777590, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFL6463PE6SBASKTHWRBXE3VWE35DANCNFSM54ZUNXOQ . You are receiving this because you authored the thread.Message ID: @.***>

Brummi commented 2 years ago

You are right :)