search

Brunel-Visualization / Brunel

Brunel Visualization
Apache License 2.0
290 stars 77 forks source link

Brunel 2.5 -- BrunelD3.geometry() with a wrong value for chart #1 in the script #284

Open cjiang-ibm opened 6 years ago

cjiang-ibm commented 6 years ago
  1. Here is the syntax we are using to generate a ACF/PACF residual chart: area x(LagValues) yrange(ACF_LCFI, ACF_UCFI) + bar x(LagValues) yrange(ACF_Residual, 0) axes(y:'Residual ACF') at(0, 0, 100, 50) | area x(LagValues) yrange(PACF_LCFI, PACF_UCFI) + bar x(LagValues) yrange(PACF_Residual, 0) axes(x, y:'Residual PACF') at(0, 50, 100, 100)

we expect to see some thing like this:

image

  1. Instead we are seeing this:

image

  1. The problem was caused by the wrong value (61 should be 94) in line 260 in attached html file --- var geom = BrunelD3.geometry(parentNode || vis.node(), 0, 0, 0.5, 1, 5, 61, 5, 0),

If I change 61 to 94 which chart #2 l(ine 586) and chart #3 ( line 1049) have, the problem will go away.

AreaPlusBarChart.html.zip

grahamwills commented 6 years ago

I was unable to replicate the exact issue, but I found two very likely culprits and fixed them. Hopefully that will fix the base issue.