search

Bruno17 / MIGX

MIGX for revo 2.2 and above
84 stars 78 forks source link

php8 compatibility #361

Closed catsmeatman closed 1 year ago

catsmeatman commented 3 years ago

After update to php8.

Deprecated: Required parameter $config follows optional parameter $resource_id in /core/components/migx/model/migx/migx.class.php:1677

Deprecated: Required parameter $criteria follows optional parameter $tvFilters in /core/components/migx/model/migx/migx.class.php:2110

Lord64 commented 3 years ago

A similar problem. Moreover, there was no problem on the nightly build of modx-2.8.3 dev-20210524. After the update to 2.8.3-pl appeared again.

BenceSzalai commented 2 years ago

This is still an issue in MigX v3.0.0-alpha5. Line numbers are different this time tho:

Required parameter $config follows optional parameter $resource_id in /core/components/migx/model/migx/migx.class.php on line 1763
Required parameter $criteria follows optional parameter $tvFilters in /core/components/migx/model/migx/migx.class.php on line 2199

Actually the issue is with the signature of these methods:

function checkForConnectedResource($resource_id = false, &$config) {
    //...
}

function tvFilters($tvFilters = '', &$criteria) {
    //...
}
ant-tar commented 1 year ago

Observes this, still is actual, MIGX 3.0.0-alpha5, MODX 3.0.2-pl

Required parameter $config follows optional parameter $resource_id in /core/components/migx/model/migx/migx.class.php on line 1763 Required parameter $criteria follows optional parameter $tvFilters in /core/components/migx/model/migx/migx.class.php on line 2199

dmitriy71n commented 1 year ago

MIGX 3.0.0-alpha5, MODX 3.0.3-pl php v8.0, v8.1, v8.2

Deprecated: Required parameter $config follows optional parameter $resource_id in /sites/site.dev/core/components/migx/model/migx/migx.class.php on line 1763

Deprecated: Required parameter $criteria follows optional parameter $tvFilters in /sites/site.dev/core/components/migx/model/migx/migx.class.php on line 2199

Bruno17 commented 1 year ago

this should have been fixed with d16c4797d9896906e2a176b94f917a34fef90ed2 and 39dc2f51d5a90d93727a40a911470cab45ed0bea

and allready be implemented since 3.0.0-beta1

dmitriy71n commented 1 year ago

Thank you. I have an old package from the repository.

сб, 26 авг. 2023 г. в 10:39, Bruno17 @.***>:

Closed #361 https://github.com/Bruno17/MIGX/issues/361 as completed.

— Reply to this email directly, view it on GitHub https://github.com/Bruno17/MIGX/issues/361#event-10198875385, or unsubscribe https://github.com/notifications/unsubscribe-auth/BCETEDF43ZV7MHVEXQHTBD3XXGR45ANCNFSM4UHMVAHQ . You are receiving this because you commented.Message ID: @.***>