BrunoLevy / geogram

a programming library with geometric algorithms
Other
1.86k stars 125 forks source link

Build is broken with clang-19: no member named 'm_N' in 'SparseMatrix<T>' #188

Open yurivict opened 6 days ago

yurivict commented 6 days ago

Clang-19 is more rigorous and is now finding missing class fields in uninstantiated and unused functions:

In file included from /wrkdirs/usr/ports/math/geogram/work/geogram-1.9.0/src/lib/geogram/third_party/PoissonRecon/poisson_geogram.cpp:61:
In file included from /wrkdirs/usr/ports/math/geogram/work/geogram-1.9.0/src/lib/geogram/third_party/PoissonRecon/SparseMatrix.h:191:
/wrkdirs/usr/ports/math/geogram/work/geogram-1.9.0/src/lib/geogram/third_party/PoissonRecon/SparseMatrix.inl:197:22: error: no member named 'm_N' in 'SparseMatrix<T>'
  197 |         Resize(this->m_N, this->m_M);
      |                ~~~~  ^
/wrkdirs/usr/ports/math/geogram/work/geogram-1.9.0/src/lib/geogram/third_party/PoissonRecon/SparseMatrix.inl:197:33: error: no member named 'm_M' in 'SparseMatrix<T>'
  197 |         Resize(this->m_N, this->m_M);
      |                           ~~~~  ^

log

BrunoLevy commented 6 days ago

Thank you for notifying.

BrunoLevy commented 2 days ago

Hello, did you have the opportunity to check again ? Does it compile now with clang-19 ? (just to know whether I can close this issue and create the new release) Thank you in advance.