search

BrunoLevy / learn-fpga

Learning FPGA, yosys, nextpnr, and RISC-V
BSD 3-Clause "New" or "Revised" License
2.58k stars 246 forks source link

FemtoRV/TOOLS/get_symbiflow.sh: fix env create #46

Closed trabucayre closed 3 years ago

trabucayre commented 3 years ago

get_symbiflow.sh is based on install instructions provided by symbiflow-examples repository. By using this script an error appear with:

$INSTALL_DIR/$FPGA_FAM/conda/bin/conda env create -f $FPGA_FAM/environment.yml
EnvironmentFileNotFound: '/somewhere/learn-fpga/FemtoRV/TOOLS/xc7/environment.yml' file not found

In getting-symbiflow.html, the authors consider that users execute commands at the root directory of symbiflow-examples. So $FPGA_FAM/environment.yml is not a path related to INSTALL_DIR but to the current directory and refers to https://github.com/SymbiFlow/symbiflow-examples/blob/master/xc7/environment.yml

This PR add two wget calls: one for environment.yml and one for requirements.txt refered by the former. conda env create line is adjusted to use yml file located in current directory instead of xc7 subdirectory

BrunoLevy commented 3 years ago

Thank you very much for this well documented PR