search

Brusalk / EventHorizon_Continued

EventHorizon_Continued for Legion+
MIT License
19 stars 15 forks source link

Doesn't work with Aurora #110

Closed n-zer closed 5 years ago

n-zer commented 6 years ago

Event Horizon doesn't work with this addon installed and enabled. It gets as far as parsing the current class config, but doesn't get to a state where the frame can be shown or the /ehz ... commands can be used.

Cluuey commented 6 years ago

@narrill does it work for you without your other addons? Have you logged a bug report with the other addon too?

I'm not the author here, that's way out of my league, but if it works without Aurora how do you know that isn't the mod causing problems?

n-zer commented 6 years ago

I figured out the problem. EventHorizon tries to get class colors from CUSTOM_CLASS_COLORS before defaulting to RAID_CLASS_COLORS, but Aurora initializes CUSTOM_CLASS_COLORS to what I assume is a non-standard format, causing EventHorizon to crash.

I don't know what CUSTOM_CLASS_COLORS is supposed to be used for (e.g. whether convention allows it to be sparse), so I don't know whether this is Aurora doing something it shouldn't or EventHorizon not validating things properly. I've opened an issue with Aurora as well, so we'll see what happens; I have a fix I can use locally in the mean time at least.

n-zer commented 5 years ago

This was apparently a bug on Aurora's end which has now been fixed, so I'm gonna close this.