search

Brusalk / EventHorizon_Continued

EventHorizon_Continued for Legion+
MIT License
19 stars 15 forks source link

Do not merge! #86

Closed Cluuey closed 6 years ago

Cluuey commented 6 years ago

I've put this here so you can see what I commented out to get rid of errors in Bugsack, I also deleted the references to LibArtifactData from the toc file. After doing that it doesn't matter if the folder is there or not, but you probably know that.

While this gets rid of the errors I can't get it to display the config. I turned debugging on and got a screen full of info I didn't know how to interpret, then I thought I'd just make the config smaller with the one which really matters to me, feral. After doing that I noticed the debug info was much shorter, then I clicked. I dropped it down to one simple debuff, it still wouldn't load. :-( I did work out what the debug message was telling me though: | spellId | debuffId | buffId | tick time | cooldown |

With the one spell in the config if I type /ehz status the result is below (manually typed as I can't find a working chat mod). It's recognising the spell in the config but it isn't making it to the draw section.


EventHorizon | DEBUG |  |  config:1
EventHorizon | Installed plugins:
EventHorizon |  redshift
EventHorizon |  lines
EventHorizon | Visible bars:
Cluuey commented 6 years ago

It just occurred to me you might want the config which worked for three of the four specs using your alpha with all the Artifact errors, no idea why it only 3/4 worked but it led me to trying to eliminate the errors in the hope that I'd get an error tell me why only 3/4 worked.

If you do let me know, I think I've still got it. I'm not sure how useful it would be vs being a waste of time though. I need to make it work with an updated core, so time spent working out why it 3/4 worked with a buggy initial alpha would just be for interests sake.

Cluuey commented 6 years ago

Instead of being a sensible lad and sleeping I worked out what was wrong with the config. cast = {48438, 5185}, It turns out 5185 was Healing Touch and it's been removed!

However I still get nothing with my hacked file with all artifact stuff taken out. It loads all 95 spells but never creates bars. :-(

Brusalk commented 6 years ago

Turns out this was due (partially) to the library not working in the patch. I updated the version of the lib included w/ the addon and it works properly now!