search

BrushXue / OpenFOAM-AppleM1

GNU General Public License v3.0
18 stars 3 forks source link

Upgrade to latest CGAL #9

Closed gerlero closed 1 year ago

gerlero commented 1 year ago

Just in case, as of v2306, latest CGAL 5.x works without any patching. If you're willing to take this change, then I'll deprecate the cgal@4 formula. Feel free to close otherwise.

BrushXue commented 1 year ago

I remember I asked Mark Oleson about the CGAL (header/lib) detection script and he said they need to redo that part. I'll double check and merge this if it works.

BrushXue commented 1 year ago

have_cgal script tells me

flavour=header_no_mpfr

But obviously CGAL is built with mpfr. https://github.com/Homebrew/homebrew-core/blob/11afaf6c7ac911a7b43141d759532ca24957d46b/Formula/c/cgal.rb#L25 I wonder if you have encountered any numerical error using foamyHexMesh or other computational geometry stuff. If all tutorial cases can be successfully executed I'm happy to use new version.

EDIT: After specifying MPFR_ARCH_PATH in etc/config.sh/CGAL, the script returns correct results.

gerlero commented 1 year ago

EDIT: After specifying MPFR_ARCH_PATH in etc/config.sh/CGAL, the script returns correct results.

Yes, missed that one. I'm setting MPFR_ARCH_PATH and GMP_ARCH_PATH in my project.

gerlero commented 1 year ago

I haven't tested all tutorial cases, but I'm always testing $FOAM_TUTORIALS/mesh/foamyHexMesh/blob; it runs fine (and has been running fine for a while)

BrushXue commented 1 year ago

Yes I just want to make sure the previous Clang -ffp-contract problem doesn't happen again.

BrushXue commented 1 year ago

The mixerVessel case failed on my Mac. Others cases are fine.

EDIT: The same case also failed on Ubuntu, so it's not our problem.

gerlero commented 1 year ago

Yeah, I've also confirmed that that case FPE's on Linux