This pull request introduces a new feature to the semantic-kernel repository, specifically focusing on enhancing the skillsets functionality. The changes primarily involve updating the method signatures to include an optional ITextCompletion parameter, which allows for more flexible and configurable text completion services. Additionally, several methods and classes have been refactored to remove deprecated functionalities and improve code clarity.
Refactored method signatures to include an optional ITextCompletion parameter, removed deprecated methods, and updated internal logic to handle the new parameter.
Updated RunAsync method calls to include the new model parameter.
Tips
- Trigger a new Sourcery review by commenting `@sourcery-ai review` on the pull request.
- Continue your discussion with Sourcery by replying directly to review comments.
- You can change your review settings at any time by accessing your [dashboard](https://app.sourcery.ai):
- Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
- Change the review language;
- You can always [contact us](mailto:support@sourcery.ai) if you have any questions or feedback.
github-actions[bot]
commented
1 month ago
Reviewer's Guide by Sourcery
This pull request introduces a new feature to the semantic-kernel repository, specifically focusing on enhancing the skillsets functionality. The changes primarily involve updating the method signatures to include an optional
ITextCompletionparameter, which allows for more flexible and configurable text completion services. Additionally, several methods and classes have been refactored to remove deprecated functionalities and improve code clarity.File-Level Changes
dotnet/src/SemanticKernel.UnitTests/Planning/PlanTests.csdotnet/src/SemanticKernel.UnitTests/Planning/PlanSerializationTests.csdotnet/src/SemanticKernel.UnitTests/TemplateEngine/Blocks/CodeBlockTests.csdotnet/src/Extensions/Extensions.UnitTests/Planning/SequentialPlanner/SequentialPlannerTests.csdotnet/src/Extensions/Extensions.UnitTests/Planning/SequentialPlanner/SequentialPlanParserTests.csITextCompletionparameter and modified mock setups to accommodate the new parameter.dotnet/src/SemanticKernel/SkillDefinition/SKFunction.csdotnet/src/SemanticKernel/Planning/Plan.csdotnet/src/SemanticKernel/Kernel.csdotnet/src/SemanticKernel.Abstractions/SkillDefinition/ISKFunction.csdotnet/src/SemanticKernel/Planning/KernelPlanExtensions.csdotnet/src/SemanticKernel.Abstractions/IKernel.csdotnet/src/SemanticKernel/SkillDefinition/SKFunctionExtensions.csITextCompletionparameter, removed deprecated methods, and updated internal logic to handle the new parameter.dotnet/src/SemanticKernel.UnitTests/KernelTests.csdotnet/src/SemanticKernel.UnitTests/Security/TrustServiceTests.csdotnet/src/IntegrationTests/Security/TrustServiceTests.csdotnet/src/SemanticKernel.UnitTests/SkillDefinition/SKFunctionTests1.csdotnet/src/IntegrationTests/Planning/PlanTests.csdotnet/src/IntegrationTests/WebSkill/WebSkillTests.csmodelparameter inRunAsyncmethod calls.samples/dotnet/kernel-syntax-examples/Example22_OpenApiSkill_AzureKeyVault.cssamples/dotnet/kernel-syntax-examples/Example23_OpenApiSkill_Github.cssamples/dotnet/kernel-syntax-examples/Example24_OpenApiSkill_Jira.cssamples/dotnet/kernel-syntax-examples/Example03_Variables.cssamples/dotnet/kernel-syntax-examples/Example12_SequentialPlanner.cssamples/dotnet/kernel-syntax-examples/Example21_ChatGPTPlugins.cssamples/dotnet/kernel-syntax-examples/Example35_GrpcSkills.csRunAsyncmethod calls to include the newmodelparameter.Tips
- Trigger a new Sourcery review by commenting `@sourcery-ai review` on the pull request. - Continue your discussion with Sourcery by replying directly to review comments. - You can change your review settings at any time by accessing your [dashboard](https://app.sourcery.ai): - Enable or disable the Sourcery-generated pull request summary or reviewer's guide; - Change the review language; - You can always [contact us](mailto:support@sourcery.ai) if you have any questions or feedback.Originally posted by @sourcery-ai in https://github.com/Bryan-Roe/semantic-kernel/pull/518#issuecomment-2266725777