search

BryanChiu / Mactivision

CS4ZP6 2020-21 Capstone group. Mini-games
4 stars 5 forks source link

Cannot Play Digger Minigame in Full Screen when Dig Button is Escape Character #98

Closed syed-razi closed 3 years ago

syed-razi commented 3 years ago

Description:

I set the Dig key to the escape character and noticed that when I'm in full screen, pressing escape escapes the screen rather than perform digging.

Environment:

Device: Macbook Pro 2015 Browser: Chrome

Steps to Reproduce:

  1. Open Battery.json
  2. Set DigKey to "Escape"
  3. Start Client and Server
  4. Enter full screen
  5. Press escape to dig

Actual Result:

Full screen minimizes to windowed mode when pressing escape rather than digging

Expected Result:

I would expect the Escape key to not be assignable as the dig key

Severity: Medium

Suggestion

Remove Escape key as an option to be one of the assignable keys

BryanChiu commented 3 years ago

We will only allow certain keys.