search

BryanCrotaz / ember-cli-userMedia

Ember addon providing cross browser access to getUserMedia
MIT License
4 stars 4 forks source link

Fix component lifecycle hooks #2

Closed zeppelin closed 8 years ago

zeppelin commented 8 years ago
  1. There is no such hook like didDestroyElement (but there is willDestroyElement)
  2. Changed willInsertElement to didInsertElement, as capturing media only makes sense in an already inserted element.
BryanCrotaz commented 8 years ago

Thanks!! I feel silly on your first fix :)

zeppelin commented 8 years ago

Don't! :)

This, however, won't fix the addon itself, as the last working version is 0.0.4.

BryanCrotaz commented 8 years ago

published :)

zeppelin commented 8 years ago

Well, the problem is that the addon is still not working...

The change that broke the app: https://github.com/BryanCrotaz/ember-cli-userMedia/pull/1/files