BryanSWeber / CUNYAIModule

CUNYBot, an AI that plays complete games of Starcraft.
MIT License
6 stars 3 forks source link

isBuildableCUNY() bug? #216

Closed BryanSWeber closed 4 years ago

BryanSWeber commented 4 years ago

Describe the bug isBuildableCUNY() does not behave as expected. In 8b0f1b0ffc051a52e0aae3ef553ce7f21ccf6c6d, line 43 of the worker manager reads:

else if(has_path && !AssemblyManager::isOccupiedBuildLocation(miner.intended_buildtype, miner.intended_buildtile)) { Mobility(unit).moveTo(unit->getPosition(), Position(miner.intended_buildtile) + Position(16,16), StoredUnit::Phase::Prebuilding);

It does not work if we replace !isOccupied with the isBuildableCUNY as expected for hatcheries out of vision.

Additional context I note BWAPI itself has the following comment in its own code: return false; // @TODO: Error code for !isExplored ??