BryanSchuetz / jekyll-deploy-gh-pages

A GitHub Action for building a Jekyll site (with custom plugins) and deploying it back to your gh-pages branch.
118 stars 60 forks source link

Eliminate the need of mandatory destination config #17

Open ibnesayeed opened 4 years ago

ibnesayeed commented 4 years ago

Forcing users to change their config files to get it working with this action is not a good out-of-the-box experience and might come in the way to their other workflow steps. It would have been better if this action would have followed the default Jekyll behavior and used _site folder instead while giving an option for users to let the action know if they have customized the destination folder. However, this action seems to be forcing the decision the other way by asking users to change their config according to the hard coded setup of this action.

In this PR I have taken an intermediary approach which does not give users the option to tell their configured destination folder, but does not ask them to change that either. I have not tested these changes yet, but I am assuming that Jekyll would give command line arguments precedence over corresponding config file entry, if present.