search

BryanSchuetz / jekyll-deploy-gh-pages

A GitHub Action for building a Jekyll site (with custom plugins) and deploying it back to your gh-pages branch.
118 stars 60 forks source link

Potential issue in README example #18

Open ibnesayeed opened 4 years ago

ibnesayeed commented 4 years ago

Are these GITHUB_REPOSITORY and GITHUB_ACTOR configurations intentional in the README Example? These values are available as environment variables in all runner environments, so why would we namespace them under secrets other than the GITHUB_TOKEN that is created by the user?

        env: 
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
          GITHUB_REPOSITORY: ${{ secrets.GITHUB_REPOSITORY }}
          GITHUB_ACTOR: ${{ secrets.GITHUB_ACTOR }}
evanw555 commented 4 years ago

github.repository and github.actor seemed to work for me.

BryanSchuetz commented 4 years ago

I'll have to look at the documentation again—at some point, I think it did have to be explicitly set but maybe that's no longer true.