replace all `throwException` patterns because `Songhay.Extensions.NullableExtensions.ToReferenceTypeValueOrThrow<T>` now exists

BryanWilhite / SonghayCore

core reusable, opinionated concerns for *all* 🧐 of my C# projects

http://songhayblog.azurewebsites.net/

MIT License

1 stars 0 forks source link

replace all `throwException` patterns because `Songhay.Extensions.NullableExtensions.ToReferenceTypeValueOrThrow<T>` now exists #143

Closed BryanWilhite closed 2 years ago

BryanWilhite commented 2 years ago

This looks like brilliant revelation (to me) but what really is effective here is getting rid of all throwException patterns in my studio with the expectation that ToReferenceTypeValueOrThrow is a sufficient, fluent replacement.

BryanWilhite commented 2 years ago

all throwException patterns cannot logically be replaced

in Songhay.Extensions.IDictionaryExtensions.TryGetValueWithKey<TKey,TValue> the throwException option is not related to nullability

any Core XML members depending on:

Songhay.Xml.XObjectUtility.GetXAttributeValue
Songhay.Xml.XmlUtility.GetNodeValue
Songhay.Xml.XObjectUtility.GetXObjects

must keep the throwException option because it is not related to nullability