BryceStevenWilley / visioning_texts

A D3 project that locally visualizes your messages from Signal or Whatsapp
GNU General Public License v3.0
37 stars 6 forks source link

Detected wrong "participants" #19

Closed biejay closed 4 years ago

biejay commented 4 years ago

Using german layout on android gives me:

WARNING: only 2 participants are supported at the moment, we parsed multiple: math.js:130 (3) ["Tim", "Tom", "Nachrichten"] 0: "Tim" 1: "Tom" 2: "Nachrichten" length: 3 __proto__: Array(0)

My format looks like this (maybe this helps): Unbenannt

With another chat it also gave me 4 "participants". And when i set my phone to USA then it didn't say "Nachrichten" but "Messages" as 3 participant.

htkcodes commented 4 years ago

I think because its reading per line, make sure each message is in a single line, the exporter might export some messages badly.

biejay commented 4 years ago

@htkcodes Hm would appreciate a fix that handles these extra lines because i got a ton of these in my conversations :D Maybe by filtering the date format and therefore detect a new message.

BryceStevenWilley commented 4 years ago

So I think this issue happens because WhatsApp will occasionally include a line that goes something like "Message to this chat are now secured with end to end encrpytion". It looks exactly like normal message line, but won't include a colon between the participant name and the body of the message. I think it can be solved with some stricter parsing, which I'll try to add tonight

BryceStevenWilley commented 4 years ago

The fix should be in @biejay, let me know if it fixes it for you!

biejay commented 4 years ago

Works! Thank you mate @BryceStevenWilley .