Brycey92 / Galaxy-Craft-Issues

This is a location to keep track of Galaxy-Craft server and pack issues and feature requests.
https://www.galaxy-craft.com
0 stars 0 forks source link

Secret Rooms X-Ray #48

Open WillKracke opened 5 years ago

WillKracke commented 5 years ago

Pack version 1.0.3

Describe the bug Putting secret rooms trapdoor allows you to see through the world

To reproduce Steps to reproduce the behavior:

  1. Place a wooden secret trapdoor on chiseled granite

Screenshots and crash reports image

Brycey92 commented 5 years ago

Does this happen when the trap door is next to other materials? Does it happen when other secret rooms blocks are placed next to chiseled granite?

WillKracke commented 5 years ago

Yeah I had to leave before I could test, reason for missing info label

WillKracke commented 5 years ago

Only occurs with chisel blocks, vanilla blocks work fine.

Brycey92 commented 5 years ago

Ok, so this happens when any nonsolid Secret Rooms block tries to copy a chisel block. This affects trap doors, ghost blocks, and stairs. It only happens when the nonsolid block is next to the same type of block it copied, and only those real blocks of the same type become xray-ified.

As a stopgap, we can ban these nonsolid blocks (#38), but this should really be fixed at the source.

Brycey92 commented 5 years ago

I opened an issue here on the Chisel github.

Brycey92 commented 5 years ago

Chisel told me it was a SecretRooms issue: https://github.com/AbrarSyed/SecretRoomsMod-forge/issues/251.