BstLabs / py-dynacli

DynaCLI is a cloud-friendly Python library for converting pure Python functions into Linux Shell commands.
https://bstlabs.github.io/py-dynacli/
MIT License
98 stars 5 forks source link

Handling direct import errors in add parser #30

Closed ShahriyarR closed 2 years ago

ShahriyarR commented 2 years ago

Change Summary

Description

The failed imports at feature and module levels should be handled properly

Fixes #24

Type of change

Please delete options that are not relevant.

Checklist:

asterkin commented 2 years ago

The issue is #30 but the branch called issue24 (I used another convention of DYNACLI#, we'd better stick to a common convention, whatever community thinks is right).

ShahriyarR commented 2 years ago

The issue is #30 but the branch called issue24 (I used another convention of DYNACLI#, we'd better stick to a common convention, whatever community thinks is right).

The issue ID is not 30, the PR ID is 30, but the actual issue ID is 24, that is why the branch name is issue_24. There are many conventions about branch naming, what I can propose let's name our branches as describe here: https://idiv-biodiversity.github.io/git-knowledge-base/branch-naming-conventions.html or here: https://deepsource.io/blog/git-branch-naming-conventions/

I did not encounter some naming as DYNACLI_# before. So as a result we could name as: 24-add-module-shortcut or issue-24

ShahriyarR commented 2 years ago

@asterkin please take another look

ShahriyarR commented 2 years ago

@asterkin PTAL. As root package imports also gave ModuleNotFoundError - it is impossible to differentiate if it was root package level import error or inner level.

ShahriyarR commented 2 years ago

@asterkin PTAL