BstLabs / py-dynacli

DynaCLI is a cloud-friendly Python library for converting pure Python functions into Linux Shell commands.
https://bstlabs.github.io/py-dynacli/
MIT License
98 stars 5 forks source link

Add .vscode to gitignore #72

Closed zyusifov closed 2 years ago

zyusifov commented 2 years ago

Change Summary

Description

Fixes # (issue)

Type of change

Please delete options that are not relevant.

Checklist:

ShahriyarR commented 2 years ago

Thanks for PR. But this is desired behavior. We have intentionally added .vscode settings to make developer experience unified. Imagine you have 5 developers who are using VSCode as development tool - if they have similar settings - you are not going to struggle with local settings of each developer.

asterkin commented 2 years ago

@ShahriyarR I was under impression that it's a common practice not to keep IDE configs in git, especially in Open Source projects. Am I wrong?

ShahriyarR commented 2 years ago

@asterkin There are myriad discussions on this topic, some of them prefer ignoring IDE specific folder some of them opt for keeping them, in our case it is useful to keep .vscode/settings.json if some developer wants to be future maintainer to make the development experience as smooth as possible, especially with code server. But yes, it is common to ignore .idea, .atom and .vscode etc, if there are multiple editor settings.

zyusifov commented 2 years ago

Thanks, I guessed that the vscode settings are needed there.