Bstn1802 / AutoReconnect

Minecraft fabric mod which automatically reconnects the client to the last known server after disconnection
https://www.curseforge.com/minecraft/mc-mods/autoreconnect
GNU Lesser General Public License v3.0
28 stars 36 forks source link

Update to 1.19.3 (Fixes #38) #40

Closed TechPro424 closed 1 year ago

TechPro424 commented 1 year ago

Fixes #38 This PR lets Minecraft launch with the mod, however, I do not know if the mod actually worked as I have not joined a server yet. Also, I got an error in the console saying that config was not loaded Will try to work on that next

TechPro424 commented 1 year ago

Just updated cloth config, resolved config errors Only thing left to do is to figure out how to join a server with the mod and get myself kicked

TechPro424 commented 1 year ago

Just tried joining a server that was not running at all to see what would happen, and game crashed So not completely working I guess

Apparently reconnectButton in DisconnectScreensMixin was null, though I don't see why

mtnair commented 1 year ago

Change

ButtonWidget reconnectButton = reconnectBuilder.dimensions(0, 0, 0, 20).build();

in DisconnectedScreensMixin.java at line 38 to

reconnectButton = reconnectBuilder.dimensions(0, 0, 0, 20).build();

And maybe you shouldn't commit the files in the remappedSrc folder (try to remove them and commit the deletion). Otherwise, great work! For me, the mod now works in 1.19.3. For testing, I kicked myself and disconnected my PC from the internet.

TechPro424 commented 1 year ago

Thanks for the feedback! I'll need a bit of time to fix it because I'm not sure if I'll be able to log on to my PC due to my final exams. Will fix it when free

On Sat, 4 Feb, 2023, 10:47 pm Martin Frühauf, < @.***> wrote:

Change ButtonWidget reconnectButton = reconnectBuilder.dimensions(0, 0, 0, 20).build(); in DisconnectedScreensMixin.java at line 38 to reconnectButton = reconnectBuilder.dimensions(0, 0, 0, 20).build( DuckDuckGo removed 1 tracker. More →

https://duckduckgo.com/-FKDTwb7ewIwkKjL89HW8oW84t2Nl11vXe34Ya6hJuBfC-vB5f7ToSSbgEizk07fXzk29y27_WldC-P7cdNnxhIJ5pkByG9gV-gTosnoXrZIGYV4KNyBcsfVooiy-Z00J2c_pYrK-RDuIzlOkf4XJbNUUpcQ7wPSSk0_MW2xwYNZ6dZI8FNjHeIxzW8M8XfESNv9glUn0fnI3fyIBE9NUVxCP9IlmwJFWPXCgUbMYbqo7sgwQXBzTKn9JJRqw259b_NO3yE2lnWBw

Change

ButtonWidget reconnectButton = reconnectBuilder.dimensions(0, 0, 0, 20).build();

in DisconnectedScreensMixin.java at line 38 to

reconnectButton = reconnectBuilder.dimensions(0, 0, 0, 20).build();

And maybe you shouldn't commit the files in the remappedSrc folder (try to remove them and commit the deletion). Otherwise, great work! For me, the mod now works in 1.19.3. For testing, I kicked myself and disconnected my PC from the internet.

— Reply to this email directly, view it on GitHub https://github.com/Bstn1802/AutoReconnect/pull/40#issuecomment-1416804122, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUU3PNJ2R4AQEZ6QUOGTHNLWV2FJTANCNFSM6AAAAAAUPCX6K4 . You are receiving this because you authored the thread.Message ID: @.***>

TechPro424 commented 1 year ago

As luck would have it, I was able to log on to my PC today

I have resolved most of the proposed changes, however, I have a doubt regarding the ButtonWidget type removal and therefore I have left that out for the time being

Why is it necessary to remove the type ButtonWidget? The build method returns a ButtonWidget type

TechPro424 commented 1 year ago

Pushed the type removal change

cunhar commented 1 year ago

<3

madKULOLO commented 1 year ago

hi, where can I download the modified mod for 1,19,3?

TechPro424 commented 1 year ago

The mod jar is inside the zip file

autoreconnect-2.1.0-beta.jar.zip

cunhar commented 1 year ago

@Bstn1802 can we get your blessing?

Bstn1802 commented 1 year ago

I noticed you've been working on the update in here, thanks for that first of all, especially to you @TechPro424. I didn't catch that it was working completely now, I'll have a look into it soon and get back to you if I have any news.