Bstn1802 / AutoReconnect

Minecraft fabric mod which automatically reconnects the client to the last known server after disconnection
https://www.curseforge.com/minecraft/mc-mods/autoreconnect
GNU Lesser General Public License v3.0
28 stars 36 forks source link

Update to 1.20.4 (Must be tested before merging) #65

Open TechPro424 opened 11 months ago

TechPro424 commented 11 months ago

Updates the mod to 1.20.4

itsTyrion commented 9 months ago

you can just check what the game does, there are 2 linked functions in the jdoc comments (@see net.minecraft.client.QuickPlay#startRealms) correct, the lambda functions just set the screen in this case. I made it cleaner in my PR (that I did without checking if there already is one xD)

TechPro424 commented 9 months ago

you can just check what the game does, there are 2 linked functions in the jdoc comments (@see net.minecraft.client.QuickPlay#startRealms) correct, the lambda functions just set the screen in this case. I made it cleaner in my PR (that I did without checking if there already is one xD)

Thanks for pointing that out! Since there are 2 PRs, do you want me to close mine or are you ok with closing yours?

(Also I think you meant startSingleplayer there instead of startRealms)

TechPro424 commented 9 months ago

Also fixed the reconnectMethod override in RealmsReconnectStrategy