search

BtbN / FFmpeg-Builds

MIT License
6.99k stars 958 forks source link

Win32 build are failing #307

Closed nihil-admirari closed 9 months ago

nihil-admirari commented 9 months ago

https://github.com/yt-dlp/FFmpeg-Builds/actions/runs/6448019034/job/17504893269:

2023-10-08T14:31:49.7191585Z 4.558 In file included from /opt/ffdl/scripts.d/50-librist/40-mbedtls.sh/library/aes.c:69:
2023-10-08T14:31:49.7192214Z 4.558 /opt/ffdl/scripts.d/50-librist/40-mbedtls.sh/library/aesni.h:69:5: error: #error "Must use `-mpclmul -msse2 -maes` for MBEDTLS_AESNI_C"
2023-10-08T14:31:49.7192769Z 4.558    69 | #   error "Must use `-mpclmul -msse2 -maes` for MBEDTLS_AESNI_C"
2023-10-08T14:31:49.7193067Z 4.558       |     ^~~~~
2023-10-08T14:31:49.7193451Z 4.617 make[2]: *** [library/CMakeFiles/mbedcrypto.dir/build.make:170: library/CMakeFiles/mbedcrypto.dir/aes.c.obj] Error 1
2023-10-08T14:31:49.7193904Z 4.620 make[1]: *** [CMakeFiles/Makefile2:252: library/CMakeFiles/mbedcrypto.dir/all] Error 2
2023-10-08T14:31:49.7194252Z 4.620 make: *** [Makefile:136: all] Error 2
BtbN commented 9 months ago

Hm, seems like mbedtls does not properly support x86 anymore. It wants specific CPU feature flags to be enabled, which would make the resulting binary just crash on CPUs not supporting it. Since people will likely use 32bit builds on ancient machines only, it seems risky to me to just enabled those flags.

So the way forward might be to just disable mbedtls and in turn librist on 32 bit builds.