BuDnA / Audio-IJS

GNU General Public License v3.0
0 stars 3 forks source link

Avoid calling sys.exit #1

Open astaric opened 6 years ago

astaric commented 6 years ago

If PyQt does not have Phonon support, do not call sys.exit (which closes orange before it was even opened)

https://github.com/BuDnA/Audio-IJS/blob/f05448f6446fe140a264be7418570b9ba9437054/orangecontrib/audio/widgets/owaudioplayer.py#L24

A better idea would be to: a) raise a python exception. Widget discovery will catch it and hide the widget b) create a widget with information on how to fix the problem. c) use alternative library

I would choose b