BuIlDaLiBlE / BetterHI3Launcher

A much better Honkai Impact 3rd launcher.
The Unlicense
102 stars 21 forks source link

Hi3HelperCore.Http Submodule Update #54

Closed neon-nyan closed 1 year ago

neon-nyan commented 2 years ago

Pull Request Overview

This Pull-Request will update the Hi3HelperCore.Http submodule, which includes some changes and fixes:

This PR is also bring some changes including:

Related Issue:

Update Per August 8th 2022

Goal

Note

Please do not merge this PR yet. The test is still in progress on my side. Will update the progress in the comment later.

Result

  1. Download is still running even already exceeded the Maximum Connections value while throwing (in this case, 8 connections) image

  2. Download finished and verification passed. Indicates that the file has been successfully downloaded without getting corrupted. image

  3. Pause/Resume button rapid-click test doesn't make any file/stream lock issue

Update

Per August 8th 2022

I made some changes on this PR to fix the bugs related to this #55 issue caused by WatchMultisessionEventProgress() trying to .Sum() size of the chunks while the chunks has already been closed.

neon-nyan commented 1 year ago

I will go make a new PR to continue the work of it. Also for clearance and to avoid confusion. Closing this PR for now