This Pull-Request will update the Hi3HelperCore.Http submodule, which includes some changes and fixes:
Fix download progress never reach 100% perfectly (only near 99-ish%)
Fix the download to go beyond 100% while retrying happened
Add default argument on MergeMultisession()
Simplify some repeated code
Now HttpHelperSessionHTTPError416 exception will be called whether the offset range is invalid or the file has been completely downloaded.
Fix the session offset on the single-session download to possibly overflowed.
Fix some state on Multi-session download never get updated
This PR is also bring some changes including:
Adding Log listener to show Inner submodule logs.
Related Issue:
[x] #53 (Need this PR to be merged first before closing)
Update Per August 8th 2022
[x] #55 (help)
[x] #56 (It still will not download after many tries) [Duplicate of #55]
Goal
[x] Testing on retryable task mechanism without stuck (throwing every 50 MiB per session)
[x] Closing Inner HTTP Response and Request to prevent flooding
[x] Finished downloading without making the file corrupted while doing retryable task testing.
[x] Make sure the out stream got disposed immediately while the Pause/Resume button pressed rapidly.
Note
Please do not merge this PR yet. The test is still in progress on my side. Will update the progress in the comment later.
Result
Download is still running even already exceeded the Maximum Connections value while throwing (in this case, 8 connections)
Download finished and verification passed. Indicates that the file has been successfully downloaded without getting corrupted.
Pause/Resume button rapid-click test doesn't make any file/stream lock issue
Update
Per August 8th 2022
I made some changes on this PR to fix the bugs related to this #55 issue caused by WatchMultisessionEventProgress() trying to .Sum() size of the chunks while the chunks has already been closed.
Pull Request Overview
This Pull-Request will update the
Hi3HelperCore.Http
submodule, which includes some changes and fixes:MergeMultisession()
HttpHelperSessionHTTPError416
exception will be called whether the offset range is invalid or the file has been completely downloaded.This PR is also bring some changes including:
Related Issue:
Update Per August 8th 2022
Goal
Note
Please do not merge this PR yet. The test is still in progress on my side. Will update the progress in the comment later.
Result
Download is still running even already exceeded the Maximum Connections value while throwing (in this case, 8 connections)
Download finished and verification passed. Indicates that the file has been successfully downloaded without getting corrupted.
Pause/Resume button rapid-click test doesn't make any file/stream lock issue
Update
Per August 8th 2022
I made some changes on this PR to fix the bugs related to this #55 issue caused by
WatchMultisessionEventProgress()
trying to.Sum()
size of the chunks while the chunks has already been closed.