BuIlDaLiBlE / BetterHI3Launcher

A much better Honkai Impact 3rd launcher.

The Unlicense

102 stars 21 forks source link

Hi3Helper.Http Submodule Update (Feb 2024) #72

Closed neon-nyan closed 4 months ago

neon-nyan commented 5 months ago

Pull Request Overview

As a continuation of PR No. #61 and due to lots of changes happened on Hi3Helper.Http since the last update on 2022. I decided to submit a PR which updates the usages and also bring some fixes (especially the Disposal Issue).

What's Changed on `Hi3Helper.Http`?

Removal of stackalloc usage and switch to heap buffer for download and merge.
Attempts on fixing disposal issues.
Reduce async overhead.
Use local CancellationToken on every method instead of instance level to avoid inconsistent cancellation result.

BuIlDaLiBlE commented 4 months ago

Thank you, a much needed update!