Bubba8291 / homebridge-sharkiq

A Homebridge plugin to connect your Shark Vacuum to homebridge.
Apache License 2.0
9 stars 1 forks source link

Always showing Docked #5

Closed donavanbecker closed 1 year ago

donavanbecker commented 1 year ago

Describe The Bug:

Run the "Fan" (Vacuum) on and it always shows dock

To Reproduce:

turn the "fan on"

Expected behavior:

Show contact sensor as opened when it is not docked.

Logs:

[8/31/2023, 10:47:42 AM] [SharkIQ] Triggering Vacuum Docked: true
[8/31/2023, 10:47:47 AM] [SharkIQ] Triggering Vacuum Docked: true
[8/31/2023, 10:47:52 AM] [SharkIQ] Triggering Vacuum Docked: true
[8/31/2023, 10:47:57 AM] [SharkIQ] Triggering Vacuum Docked: true
[8/31/2023, 10:48:02 AM] [SharkIQ] Triggering Vacuum Docked: true
[8/31/2023, 10:48:07 AM] [SharkIQ] Triggering Vacuum Docked: true
[8/31/2023, 10:48:12 AM] [SharkIQ] Triggering Vacuum Docked: true
[8/31/2023, 10:48:17 AM] [SharkIQ] Triggering Vacuum Docked: true
[8/31/2023, 10:48:22 AM] [SharkIQ] Triggering Vacuum Docked: true
[8/31/2023, 10:48:28 AM] [SharkIQ] Triggering Vacuum Docked: true
[8/31/2023, 10:48:32 AM] [SharkIQ] Triggering Vacuum Docked: true
[8/31/2023, 10:48:37 AM] [SharkIQ] Triggering Vacuum Docked: true
[8/31/2023, 10:48:42 AM] [SharkIQ] Triggering Vacuum Docked: true
[8/31/2023, 10:48:47 AM] [SharkIQ] Triggering Vacuum Docked: true
[8/31/2023, 10:48:52 AM] [SharkIQ] Triggering Vacuum Docked: true
[8/31/2023, 10:48:57 AM] [SharkIQ] Triggering Vacuum Docked: true
[8/31/2023, 10:49:02 AM] [SharkIQ] Triggering Vacuum Docked: true
[8/31/2023, 10:49:07 AM] [SharkIQ] Triggering Vacuum Docked: true
[8/31/2023, 10:49:12 AM] [SharkIQ] Triggering Vacuum Docked: true
[8/31/2023, 10:49:18 AM] [SharkIQ] Triggering Vacuum Docked: true
[8/31/2023, 10:49:22 AM] [SharkIQ] Triggering Vacuum Docked: true
[8/31/2023, 10:49:27 AM] [SharkIQ] Triggering Vacuum Docked: true
[8/31/2023, 10:49:33 AM] [SharkIQ] Triggering Vacuum Docked: true
[8/31/2023, 10:49:37 AM] [SharkIQ] Triggering Vacuum Docked: true
[8/31/2023, 10:49:42 AM] [SharkIQ] Triggering Vacuum Docked: true
[8/31/2023, 10:49:47 AM] [SharkIQ] Triggering Vacuum Docked: true
[8/31/2023, 10:49:52 AM] [SharkIQ] Triggering Vacuum Docked: true
[8/31/2023, 10:49:57 AM] [SharkIQ] Triggering Vacuum Docked: true
[8/31/2023, 10:50:03 AM] [SharkIQ] Triggering Vacuum Docked: true
[8/31/2023, 10:50:07 AM] [SharkIQ] Triggering Vacuum Docked: true
[8/31/2023, 10:50:12 AM] [SharkIQ] Triggering Vacuum Docked: true
[8/31/2023, 10:50:17 AM] [SharkIQ] Triggering Vacuum Docked: true
[8/31/2023, 10:50:22 AM] [SharkIQ] Triggering Vacuum Docked: true
[8/31/2023, 10:50:27 AM] [SharkIQ] Triggering Vacuum Docked: true
[8/31/2023, 10:50:32 AM] [SharkIQ] Triggering Vacuum Docked: true
[8/31/2023, 10:50:38 AM] [SharkIQ] Triggering Vacuum Docked: true
[8/31/2023, 10:50:42 AM] [SharkIQ] Triggering Vacuum Docked: true
[8/31/2023, 10:50:47 AM] [SharkIQ] Triggering Vacuum Docked: true
[8/31/2023, 10:50:52 AM] [SharkIQ] Triggering Vacuum Docked: true
[8/31/2023, 10:50:57 AM] [SharkIQ] Triggering Vacuum Docked: true
[8/31/2023, 10:51:02 AM] [SharkIQ] Triggering Vacuum Docked: true
[8/31/2023, 10:51:07 AM] [SharkIQ] Triggering Vacuum Docked: true
[8/31/2023, 10:51:12 AM] [SharkIQ] Triggering Vacuum Docked: true
[8/31/2023, 10:51:17 AM] [SharkIQ] Triggering Vacuum Docked: true

Plugin Config:

{
            "name": "SharkIQ",
            "email": "email@email.com",
            "password": "12345678",
            "platform": "SharkIQ",
            "vacuums": [
                "XXXXXXXX"
            ]
        }

Screenshots:

image

Environment:

macOS (hb-service)

donavanbecker commented 1 year ago

When Vacuum is undocked it should show Opened and when it is docked it should show closed.

Bubba8291 commented 1 year ago

I programmed the sensor to show as "opened" when it's docked and "closed" when it's not docked.

Bubba8291 commented 1 year ago

I can flip it if it makes more sense to people for docked to display as "open" when it's not docked. I'll specify it in the readme for now.

donavanbecker commented 1 year ago

Could you just add a config option to allow the setting to be flipped?

Bubba8291 commented 1 year ago

I updated it. Can you add a pr with the layout options for the invert setting in the config.schema.json?

donavanbecker commented 1 year ago

See #6

donavanbecker commented 1 year ago

Thanks for adding this!