Bubbet / Risk-Of-Rain-Mods

The source for all of my risk of rain mods, even ones not yet released.
2 stars 4 forks source link

Breaks Void Fields' Void Cell Vents #118

Closed BlackjackMKV closed 2 months ago

BlackjackMKV commented 2 months ago

Heya! Playing with our modpack we made post-Devotion, we found that the Void Cell Vents didn't work. You could activate them and stand in the area of effect to make progress on it like usual, but, on completion, while the air bubble would shrink as though it was completed, it wouldn't spawn any items at all nor count as finished for the 0/9 Cell Vents objective. Instead of showing 1/9 like it should have, it would remain stuck at 0/9, and it wouldn't activate the next one, resulting in progressing past the first vent being entirely impossible. After a bunch of troubleshooting, we eventually narrowed it down to this mod, which is a shame since I really love this mod and what it adds.

We did consider that it could be a mod conflict(we've had several of those, since we have about a hundred or so), but even testing with just this mod(BubbetsItems 1.8.8) and Aerolt for debugging, it seems to happen even with only this one installed. It does, when the cell vent finishes, kick this error into the console, if it helps:

[Error : Unity Log] MissingMethodException: void RoR2.PickupDropletController.CreatePickupDroplet(RoR2.GenericPickupController/CreatePickupInfo,UnityEngine.Vector3,UnityEngine.Vector3) Stack trace: RoR2.ArenaMissionController.EndRound () (at <78ca0507428e4dbea7a28fe14402f720>:IL_0005) DMD<>?-599364352.Trampoline<RoR2.ArenaMissionController::EndRound>?-1279538176 (RoR2.ArenaMissionController ) (at <798ed9a237be4c98ab82445330eaebf1>:IL_0020) SVoidBarnacle.Hook.ArenaMissionController_EndRound (On.RoR2.ArenaMissionController+orig_EndRound orig, RoR2.ArenaMissionController self) (at <226eb7ef98fd4f4696fc85c2bd1720cf>:IL_0001) DMD<>?-599364352.Hook<RoR2.ArenaMissionController::EndRound>?-2001681792 (RoR2.ArenaMissionController ) (at <b3dfc443b5f24128a12fb95fe064ef02>:IL_000A) DMD<>?-599364352.Trampoline<RoR2.ArenaMissionController::EndRound>?1288539136 (RoR2.ArenaMissionController ) (at <9a82bf519fba4928b969aea96bc0d35f>:IL_0020) EnforcerPlugin.EnforcerModPlugin.ArenaMissionController_EndRound (On.RoR2.ArenaMissionController+orig_EndRound orig, RoR2.ArenaMissionController self) (at <c355e0c5a16e4bab8a4e8c240d630c3d>:IL_0001) DMD<>?-599364352.Hook<RoR2.ArenaMissionController::EndRound>?931062016 (RoR2.ArenaMissionController ) (at <ddd062cfd7254a9ca16a19c89349b5b7>:IL_0014) EntityStates.Missions.Arena.NullWard.Complete.OnEnter () (at <78ca0507428e4dbea7a28fe14402f720>:IL_004A) DMD<SetState>?-599364352._RoR2_EntityStateMachine::SetState (RoR2.EntityStateMachine this, EntityStates.EntityState newState) (at <131354b87f094de482f184f4f96b3b62>:IL_005C) DMD<>?-599364352.Trampoline<RoR2.EntityStateMachine::SetState>?-813519872 (RoR2.EntityStateMachine , EntityStates.EntityState ) (at <bcb4eb8549874a438ddb43e8d0e35a3d>:IL_0020) EnforcerPlugin.EnforcerModPlugin.EntityStateMachine_SetState (On.RoR2.EntityStateMachine+orig_SetState orig, RoR2.EntityStateMachine self, EntityStates.EntityState newState) (at <c355e0c5a16e4bab8a4e8c240d630c3d>:IL_005A) DMD<>?-599364352.Hook<RoR2.EntityStateMachine::SetState>?1301142528 (RoR2.EntityStateMachine , EntityStates.EntityState ) (at <b074ba10e0144163a8b588aefd0207e9>:IL_0014) RoR2.EntityStateMachine.FixedUpdate () (at <78ca0507428e4dbea7a28fe14402f720>:IL_0008)

Looking at the error, if I had to guess, they probably changed the void method's name to something else, though I could be wrong.

Bubbet commented 2 months ago

Close, they changed the method signature, it used to take a class/struct that housed the pickup index and some other data as the first parameter now its just the pickup index.

Bubbet commented 2 months ago

more accurately there was an overload for that and now there isn't. so when trying to spawn the void coins it crapped itself. thanks for the report

BlackjackMKV commented 2 months ago

Ah, makes sense. And no problem. I super love your mod, so I was hyper dismayed to find it wasn't working properly anymore. Thanks for the quick reply! I look forward to hopefully playing with it again once that problem's fixed! :)

Bubbet commented 2 months ago

should be fixed now