search

Bubbit / wct-istanbub

11 stars 5 forks source link

[WIP] Update to newest `istanbul-*` dependencies. #16

Closed Westbrook closed 5 years ago

Westbrook commented 6 years ago

The goal of this is to add support for importMeta. Currently, that is blocked by this issue https://github.com/istanbuljs/istanbuljs/issues/202

If I see positive movement/velocity on the subsequent PR there I'll leave this as is in anticipation of a new release. If not, I'll point this to a fork of the istanbul-lib-instrument until I do.

Will fix: https://github.com/Bubbit/wct-istanbub/issues/15

Bubbit commented 6 years ago

Hoi, currently unavailable to check it out as I'm on a short trip, will be able to do check it on Friday, sorry for the delay

Westbrook commented 6 years ago

No specific hurry, enjoy the trip! 🏖

Westbrook commented 5 years ago

Today's update adds Babel support for importMeta to the Istanbul plugins via a plugins variable. This will covert all of the advanced support required to match https://github.com/Polymer/tools/blob/master/packages/build/src/js-transform.ts#L89 while leaving the opportunity to easily add further plugins, or the far future possibilities of adding plugins to Istanbub via an options parameter were that seen as a benefit (i.e. were testing certain unused features causing performance issues.

With this, and the releases upstream by Istanbul and NYC, I'm comfortable moving forward with this from a feature standpoint, let me know if there is anything form the structure standpoint that you feel deserves addressing at this time.