Upgraded html-script-hook to 1.0.0

Bubbit / wct-istanbub

11 stars 5 forks source link

Closed akonoupakis closed 5 years ago

akonoupakis commented 5 years ago

Upgraded html-script-hook to v1.0.0. Hoping that this upgrade will fix malformed json within html comments.

Bubbit commented 5 years ago

Thanks for the pull request.

Sadly (I'm aware of the issue, although not described in the PR) I'm not merging it due to two reasons:

Changelog is not updated
I don't hope, I make sure ;) considering the only change between 0.10.0 and 1.0.0 is the version: https://github.com/apowers313/html-script-hook/compare/0.10.0...master I don't see how this should help.

akonoupakis commented 5 years ago

Thanks for the insight, reached the same conclusion