search

Bubbit / wct-istanbub

11 stars 5 forks source link

include option is modified #7

Closed justincy closed 6 years ago

justincy commented 6 years ago

The include option is modified. Why? One would assume that devs would set include and exclude globs to sufficiently limit files.

https://github.com/Bubbit/wct-istanbub/blob/master/lib/middleware.js#L105-L118

If I submitted a PR to change this, how would you prefer that it be handled? Remove the modifications or add an option to skip the modification?

Bubbit commented 6 years ago

That was done related to: https://github.com/Bubbit/wct-istanbub/issues/1, if you still have use-cases in order to remove the default modification I would opt for the 2nd approach, adding an option to skip it :)