search

BubblyYi / Coronary-Artery-Tracking-via-3D-CNN-Classification

The PyTorch re-implement of a 3D CNN Tracker to extract coronary artery centerlines with state-of-the-art (SOTA) performance. (paper: 'Coronary artery centerline extraction in cardiac CT angiography using a CNN-based orientation classifier')
MIT License
187 stars 40 forks source link

search_one_direction function #14

Closed DanniLi36 closed 3 years ago

DanniLi36 commented 3 years ago

Hi,

I have ran vessels_tree_infer.py and found something wrong with the search_one_direction in build_vessel_tree.py. Condition of the while loop keep unchanged so that's an infinite loop and cannot run a result. How to solve the problem? Thank you.

image

DanniLi36 commented 3 years ago

In line 194, since 'start' is unchanged, so 'result' is also unchanged. Following variables are also unchanged (prob_mean). I suppose that 'move_direction' and 'next_point' will change, but the move function just always give the same output. Thus, 'find_node_initial' is always None. The while loop thus infinite.

seekincs commented 3 years ago

In line 194, since 'start' is unchanged, so 'result' is also unchanged. Following variables are also unchanged (prob_mean). I suppose that 'move_direction' and 'next_point' will change, but the move function just always give the same output. Thus, 'find_node_initial' is always None. The while loop thus infinite.

Yes, this problem does exist, you need to update the start variable.

image

BubblyYi commented 3 years ago

Hi DanniLi36 and seekincs Thank you for pointing out this problem. I have updated the code to fix this problem. Please update to the latest version and try again. https://github.com/BubblyYi/Coronary-Artery-Tracking-via-3D-CNN-Classification/blob/280b98c0025e474f9a403bc89f3f7cf2fe328dbd/infer_tools_tree/build_vessel_tree.py#L202