search

BudSystemLimited / Cake.DocumentDb

MIT License
1 stars 0 forks source link

Recommended changes resulting from automated audit #11

Open Jericho opened 6 years ago

Jericho commented 6 years ago

We performed an automated audit of your Cake addin and found that it does not follow all the best practices.

We encourage you to make the following modifications:

Apologies if this is already being worked on, or if there are existing open issues, this issue was created based on what is currently published for this package on NuGet.org and in the project on github.

gep13 commented 5 years ago

@romanbuduk it would be great if some of the other suggestions in this issue could be addressed as well.

The main one being updating to the latest recommended version of Cake, which is now 0.33.0 (rather than 0.28.0), and also to compile this addin for netstandard2.0.

Is this something that is be planned to be addressed?

The need for a YAML file has already been addressed, so that it not required to be completed anymore.

romanbuduk commented 5 years ago

@gep13 we'll consider these changes next time we update/bugfix the package, but there are no updates planned. Feel free to raise a PR if you need this urgently.

gep13 commented 5 years ago

@romanbuduk happy to make a PR to get this updated.

Do you think it would make sense to move this Repository under the Cake Contrib Organisation on GitHub? It has already been added to the Cake-Contrib Organisation on NuGet. Moving it into the Organisation would mean that more people would be able to help with the maintenance required to keep the addin up to date.

gep13 commented 4 years ago

@romanbuduk I just wanted to follow up with the above question. What are your thoughts on this? Thanks