search

BuddhaNexus / buddhanexus-frontend-next

BuddhaNexus Frontend 2.0
2 stars 0 forks source link

Padding on match numberr #104

Closed ayya-vimala closed 8 months ago

ayya-vimala commented 11 months ago

Number of matches at the top of the right viewport in text-view mode needs some padding on the left.

Image

aminahbl commented 11 months ago

Thanks @ayya-vimala. Can you gives some more context for this. I've tested on FF and Chrome, desktop & mobile simulator and can't reproduce. What are you using?

The image feels a bit off for me, because the matches indicator uses a chip:

Image

Image

The description says text view, but the image is from table view. In any case, both use the same component with the chip… 🤔

ayya-vimala commented 9 months ago

It's in text view using Chrome on Ubuntu.

If you select a text and see the colored segments in there, you can click on one of those and another column opens on the right showing the matches for that specific segment. At the top of that column it shows the number of matches found for that segment. That number needs a little padding on the left as it's wedged against the dividing line as per scteenshot.

aminahbl commented 9 months ago

Yeah, I think this might have been for an old version. Above is a screenshot for Text View.

aminahbl commented 9 months ago

Happend to be having a look at text-view (I haven't been working on text view so I'm not very familiar with it) and now I get you, it's the line matches within the text in text-view. I'll updated the description picture for added context.

TrebuhD commented 8 months ago

@ayya-vimala this UI was work-in-progress. It can still be polished, but it should look like this now :) Screenshot from the version currently deployed online:

image image