search

BuddhaNexus / buddhanexus-frontend-next

BuddhaNexus Frontend 2.0
buddhanexus-frontend-next.vercel.app
2 stars 1 forks source link

Refactor API types to align with codegen BE types #147

Closed aminahbl closed 1 month ago

aminahbl commented 1 month ago

About

Please review the readme for new api typing conventions: https://github.com/BuddhaNexus/buddhanexus-frontend-next/tree/api-types?tab=readme-ov-file#api-befe-intergration

ayya-vimala commented 1 month ago

I can't really review the code but when trying to run it on my backend branch locally I notice that the text-view doesn't give any matches any more. In the main frontend-branch that still worked (on the same backend branch). The rest seems to work fine (although some known bugs persist)

ayya-vimala commented 1 month ago

YEAH! Works now!

aminahbl commented 1 month ago

I can't really review the code but when trying to run it on my backend branch locally I notice that the text-view doesn't give any matches any more. In the main frontend-branch that still worked (on the same backend branch). The rest seems to work fine (although some known bugs persist)

I got to the bottom of this. The highlight data was missing, because when updating the text-parallels query, I didn't include:

multi_lingual: ["skt", "pli", "chn", "tib"]

In the request body. When the handling for the multi_lingual (to be renamed available_languages) has been fully implemented this should be passed to the body like all the other queries, but in the meantime it needed to be hardcoded. Thanks so much for highlighting (pun intended ;-)).

I've also updated the DB url.

aminahbl commented 1 month ago

YEAH! Works now!

Gosh that was quick, I didn't even let you know I'd done it before you confirmed!!! :raised_hands: