search

BuddhaNexus / buddhanexus

Backend for the Buddhanexus project
8 stars 2 forks source link

Datalaoder small fix #256

Closed sebastian-nehrdich closed 2 months ago

sebastian-nehrdich commented 5 months ago

Small bugfixes

ayya-vimala commented 2 months ago

I'd like to merge this into development, esp. since you are already going to rebuild the whole dataloader. But please make sure that the build is working. I cannot see what is wrong with it but it fails. It seems to have to do something with the dependencies. https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/ https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

sebastian-nehrdich commented 2 months ago

I have updated pull request verification pipeline, travis checks this succesfully. There seem to be a problem with the travis CI branch status not being reported on time - not sure what we want to do with this, I am fine with just ignoring it

ayya-vimala commented 2 months ago

I usually ignore Travis ... we discarded that last year but it's still in there for some reason. As long as the github build is working I'm happy.