search

BuddhaNexus / buddhanexus

Backend for the Buddhanexus project
8 stars 2 forks source link

Merge Frontend #268

Closed TrebuhD closed 1 month ago

TrebuhD commented 1 month ago

This adds a frontend folder containing all the client app code.

codeclimate[bot] commented 1 month ago

Code Climate has analyzed commit 0dd552bd and detected 93 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 51
Duplication 42

View more on Code Climate.

aminahbl commented 1 month ago

Thanks so much @TrebuhD! Overall, seems good and everything works as expected. :raised_hands: :pray:

I'm a bit lost over what is pulling from/to where... I tried to create a patch (https://github.com/BuddhaNexus/buddhanexus-next/pull/1) while reviewing, but subsequently noticed that GH created it on buddhanexus-next rather than this repo (and also there are two masters and :dizzy_face: ...)

It would probably be good to add a line or two to the main readme on the update.

TrebuhD commented 1 month ago

@aminahbl thank you for reviewing!

Your patch was likely pointing at the repository fork. This will be deleted after this is merged. Thus, there will be only one master and probably no need for any additions to the readme regarding this. Please let me know how that sounds :)

aminahbl commented 1 month ago

Yeah, I figured the double master would be resolved on merge.

The readme update suggestion was more general. I don't really know the conventions for documenting monorepos, but it strikes me that with this merge the current readme isn't wholly reflective of the project. If this is the norm, all good.

TrebuhD commented 1 month ago

Yes, we should add a note to the general README pointing at the one inside the frontend folder, I'll do this, thanks.

It looks like I also need to solve some CI checks here.

Just for clarity, this is arguably not a monorepo, or just a sort-of a monorepo - technically this is all one project. We also don't use any monorepo tooling like nx, turborepo or yarn monorepos. Docker will hold everything together :).