search

BuddhaNexus / buddhanexus

Backend for the Buddhanexus project
8 stars 2 forks source link

Links at bottom of menu #286

Open ayya-vimala opened 7 months ago

ayya-vimala commented 7 months ago

Image

All the sites are mentioned at the bottom of the menu and not just the ones that are relevant for the text in question. So for a Pali text this should be only SC (for DN, MN, AN, SN and KN) and VRI for all pali texts. Same with the other languages. The /links/external/ API call gives back which links are relevant. For instance it gives back:

{
  "bdrc": "False",
  "rkts": "False",
  "gretil": "False",
  "dsbc": "False",
  "cbeta": "False",
  "suttacentral": "https://suttacentral.net/dn5",
  "cbc": "False",
  "vri": "https://www.tipitaka.org/romn/"
}
ayya-vimala commented 6 months ago

I guess I could have it filter the backend to give back only those that are not false, but would that work with the typescript?

aminahbl commented 6 months ago

It didn't used to render this way. My guess is there some small bit of logic that needs to be updated.

aminahbl commented 5 months ago

Yeah I see what's going on, I think the BE used to return a null value, which the FE checked against, not it returns "False" which as a string with length is truthy. Will fix.

ayya-vimala commented 2 months ago

This doesn't work for all texts. Esp. Sanskrit. Chinese I cannot check as I don't have the Chinese data in BN2. F.i. doesn't work for: https://buddhanexus2.kc-tbts.uni-hamburg.de/db/skt/T04nagmmk_u/text I will check on backend.

ayya-vimala commented 2 months ago

This works for Pali and for Tibetan but not for Sanskrit and for Chinese there are no texts yet. I think it's a backend issue that needs to be checked once new data has been uploaded to the backend.

ayya-vimala commented 1 week ago

Still some issues, probably using wrong branch.