search

BuddiesOfBudgie / budgie-control-center

Budgie Control Center is a fork of GNOME Control Center for the Budgie 10 Series.
GNU General Public License v2.0
26 stars 14 forks source link

WIP: Add a panel to configure budgie-desktop-view #67

Closed BlindRepublic closed 9 months ago

BlindRepublic commented 9 months ago

Description

Adds a panel to configure basic settings for budgie-desktop-view similar to that of Budgie Desktop Settings. This is not final as I don't know how to handle the category and icon for the settings list button. I really just based this off of the original settings page and what I could gleam from other pages in this application, so all feedback is welcome.

Submitter Checklist

JoshStrobl commented 9 months ago

I am not sure it is worth the effort of doing this when it is already in Budgie Desktop Settings, which also supports other desktop icon implementations such as Nemo and DesktopFolders. This would be a regression and adds to the fragmentation.

BlindRepublic commented 9 months ago

Okay, I have implemented support for other desktop managers...

I am not sure it is worth the effort of doing this when it is already in Budgie Desktop Settings...

This is worth the effort as the current experience doesn't make much sense to an end user with only some functionality implemented in BDS and some in BCC. From what I can tell, it would take more work to port everything from BCC to BDS than vice-versa.

JoshStrobl commented 9 months ago

Users are going to be using both Budgie 10 ceases to exist, I am not convinced that moving it to a codebase that is more cumbersome to iterate on is a benefit. Budgie 11's control center will be from scratch, the merge of items makes sense to happen then. This is just going to cause items that have been in BDS for years that users have come to expect to be there to disappear, with no benefit and the expectation that they mentally retrain to go to the new location.

JoshStrobl commented 9 months ago

I have decided to close this PR given my thoughts above. I appreciate the time you have put into this, I am hopeful that in the future you will ask for thoughts on the worthwhile of these sort of things before venturing to doing this work. Breaking existing user flows and moving code from known good iterable locations to codebases we would rather not have are two things I very much would like to avoid. I am excited for the split between BDS and BCC to be solved for 10, but in the meantime I am happy to maintain the current status quo to avoid adding more painpoints. Our focus on 10 series needs to be on Wayland support and the work to facilitate that. We can't keep adding more baggage and more extraneous work only to be impacting our time spent on closure of 10 and implementing 11.

BlindRepublic commented 9 months ago

Okay... I was not aware that 11's center would be from scratch.

JoshStrobl commented 9 months ago

@BlindRepublic Budgie 11 itself is effectively Budgie from scratch. Designed to be Wayland only, use no libraries related to the GNOME Stack (Mutter, GTK, GNOME Settings Daemon, etc), separate data / presentation models, and so forth :)