search

BuddiesOfBudgie / budgie-desktop-view

Budgie Desktop View is the official Budgie desktop icons application / implementation.
Apache License 2.0
29 stars 8 forks source link

Use correct path for building xdg_appdir value. #13

Closed arrowd closed 1 year ago

arrowd commented 1 year ago

The get_option('sysconfdir') by itself doesn't contain prefix. Use confdir variable instead, which is in line with datadir variable usage.

Original patch by Olivier Duchateau duchateau.olivier@gmail.com @OlivierDuchateau

JoshStrobl commented 1 year ago

Original patch by Olivier Duchateau duchateau.olivier@gmail.com @OlivierDuchateau

Crediting in this manner isn't really desired, your commit info will already indicate your name and email. Feel free to remove it from your commit message itself. Patch itself is fine.

arrowd commented 1 year ago

commit info will already indicate your name and email.

Which is why I put the original author's name in the commit's message. I can remove it if you insist.

JoshStrobl commented 1 year ago

Which is why I put the original author's name in the commit's message. I can remove it if you insist.

No, it's part of the commit metadata itself (git authorship info). You don't need the description text at all.

arrowd commented 1 year ago

It is a pity that this didn't get into the 1.2.1 release.

JoshStrobl commented 1 year ago

Sorry, slipped my mind in the prep for all the Budgie stuff.