search

BuddiesOfBudgie / budgie-desktop-view

Budgie Desktop View is the official Budgie desktop icons application / implementation.
Apache License 2.0
29 stars 8 forks source link

Failed to compile with meson 1.4.0 #29

Closed SpidFightFR closed 4 months ago

SpidFightFR commented 4 months ago

Hello, i encounter a problem while compiling budgie-desktop-view using meson 1.4.0. It used to work with meson 1.3.2, however after an update of meson, the build process fails with these errors:

I'm pretty sure i'm missing something, a dependency required after the meson 1.4.0 update, or a setting that needs to change using a patch... Anyway - something that i missed here.

Thank you by advance for your help. Don't hesitate to ping me or ask me if you need more info. Logs attached, it's a giant wall of text tho...

meator commented 4 months ago

It looks like Meson version 1.2.0 and 1.3.2 add the -w flag to the command line ~for some unknown reason~. This negates all warning related flags, in particular:

-Werror -Wconversion -Wformat -Wformat-security -Wstack-protector -Wundef -Wuninitialized

Meson 1.4.0 appears to have fixed this bug ~(?)~, so warnings are enabled again. They cause the build to fail because of -Werror.

EDIT: I have since confirmed that this is a bug fixed in Meson 1.4.0: https://github.com/mesonbuild/meson/pull/12597

meator commented 4 months ago

Usage of -Werror in release builds can have unintended consequences (like here). -Werror should only be used when developing the project.

JoshStrobl commented 4 months ago

Duplicate of #28