Closed EbonJaeger closed 11 months ago
Testing with Discord and seems a bit busted. Incorrect title and notification group icons aren't that of the application, just of the first icon of the first notification you get. Provided details in Matrix.
@serebit Could you clarify what styling changes you are referring to?
raven-notifications-group
. The Raven Notifications Group Header is still aligned with group item headers, which was the purpose of margin and padding offsets, and the use of the inner box instead of the group itself being the box is still valid as we referenced the group without a parent selector (so it can be any child) and the inner list is still a valid selectorraven-notifications-view
, saw no related changes from what I can tell.It looks identical to me, but I do need to get my eyes checked sooooo.
Description
This does a couple of things. First, when constructing a notification group, just get the image directly from our Notification object. We did all the work to get the correct image, let's actually use it.
Secondly, remove our HashTable mapping application name to notification group. We don't need it; anything it was used for we can get from the ListBox. This avoids having to keep track of groups in multiple data structures (the table and the list box). This makes the code easier to maintain, and slightly more memory efficient.
The NotificationGroup widget has been changed to a
Gtk.ListBoxRow
to make it easier to find and remove groups from the view.Lastly, switch to
ngettext
to build the text for the notification view header instead of an if/elseif chain.Fixes #450
Submitter Checklist
git rebase -i
(if needed)