search

BuddiesOfBudgie / budgie-desktop

Budgie Desktop is a familiar, modern desktop environment.
https://buddiesofbudgie.org
GNU General Public License v2.0
928 stars 47 forks source link

Notification icons broken [Bug] #477

Closed solomongrundy6 closed 10 months ago

solomongrundy6 commented 10 months ago

Description

I mentioned this in a comment in the old issue, but it didn't seem to get noticed and it wouldn't let me re-open the issue, so I'm posting a new one for visibility. After updating to 10.8.1, notification icons in raven's notification widget are more broken than before. More icons do not work properly now and give the default GTK missing icon image. None of the broken icons that I'm encountering now are custom or referencing something I've modified, so I'm fairly certain it's not a naming issue this time - even nemo's notification about ejecting a USB drive has a broken image. And many of the icons that are broken are not referencing a file on disk anyway, as they are only data streams sent through dbus. (streamlink-twitch-gui notifying you of a channel coming online is an example.) The icons used by the actual notification that pops up are fine, this is only in the Raven notification widget.

If it matters, I use the Papirus-Light icon theme, but changing themes doesn't seem to change anything with this bug.

screenshot

Budgie version

10.8.1

Operating System

Solus 4.4

Steps to reproduce the issue

Trigger a notification by ejecting a USB drive in nemo or doing various things in lots of apps, then check Raven.

Actual result

screenshot

Expected result

correct icon being used

Additional information

No response

EbonJaeger commented 10 months ago

Can you give more examples of broken notifications? I think I just fixed this locally (Nemo works now), but I would like more testing data.

solomongrundy6 commented 10 months ago

I can't think of any immediately off the top of my head, but if I come across them again I'll mention them here. Nemo and streamlink-twitch-gui were the two big ones. All of my notify-send ones are working fine.

solomongrundy6 commented 10 months ago

The only other broken tooltip I've come across that I forgot about was the Mullvad VPN client, and just glancing at the notification it makes with dbus-monitor makes me think your fix will correct that one too. (It's another one that passes an icon over dbus instead of referencing a file.) Thanks for all the help and patience!