BuddiesOfBudgie / budgie-desktop

Budgie Desktop is a familiar, modern desktop environment.
https://buddiesofbudgie.org
GNU General Public License v2.0
928 stars 47 forks source link

notifications: Try to guess app id if getting from hints fails #479

Closed EbonJaeger closed 10 months ago

EbonJaeger commented 10 months ago

Description

The notification spec states that the desktop-entry hint should be the prefix of the Desktop Application Info file. However, because of the push to have fully-qualified app ID's, some applications now have a mismatch between the ID and the desktop file, meaning the hint cannot be used for that application.

In cases where the hint fails, try to guess the ID using the application's name given to us from DBus.

It seems to fix https://github.com/BuddiesOfBudgie/budgie-desktop/issues/477.

Original description:

The spec states that the image data from a notification should be used before the application icon or any other icon. This change should reflect that.

It seems to fix #477. Nemo and Twitch Streamlink notifications now display properly in Raven on my system.

Signed-off-by: Evan Maddock maddock.evan@vivaldi.net

Submitter Checklist

JoshStrobl commented 10 months ago

This change will result in Discord iconography being that of the avatar of the first avatar of the first person / channel / server you get a notification from, regardless of whether or not any other notifications come from the same source, That's why I have it set to prioritize the app info image.

JoshStrobl commented 10 months ago

See https://github.com/BuddiesOfBudgie/budgie-desktop/pull/452/commits/6c0608b0649cbb7b2faa296c427038800568eb3d

The specification is for the Notification itself, it shouldn't dictate how it should be handled in Raven. I would be curious what sort of AppInfo we are getting from those applications sending the notifications.

EbonJaeger commented 10 months ago

Gonna give this more thought...

EbonJaeger commented 10 months ago

Thought given.

EbonJaeger commented 10 months ago

Found two more things bork: Solus Update Service and budgie-daemon when we get the notification that there are notifications.