search

BuddiesOfBudgie / budgie-desktop

Budgie Desktop is a familiar, modern desktop environment.
https://buddiesofbudgie.org
GNU General Public License v2.0
957 stars 50 forks source link

[Bug] FTBFS with libxfce4windowing 4.19.4: undefined reference to `xfw_window_x11_get_xid' #603

Closed bobby285271 closed 2 months ago

bobby285271 commented 2 months ago

Description

It's me again :joy:

For some reason the introduction of XfwMonitor (?) breaks budgie-desktop again:

[425/478] Linking target src/daemon/budgie-daemon
FAILED: src/daemon/budgie-daemon 
gcc  -o src/daemon/budgie-daemon src/daemon/budgie-daemon.p/meson-generated_endsession.c.o src/daemon/budgie-daemon.p/meson-generated_notifications_dbus.c.o src/daemon/budgie-daemon.p/meson-generated_notifications_popup.c.o src/daemon/budgie-daemon.p/meson-generated_screenshot.c.o src/daemon/budgie-daemon.p/meson-generated_statusnotifier.c.o src/daemon/budgie-daemon.p/meson-generated_main.c.o src/daemon/budgie-daemon.p/meson-generated_manager.c.o src/daemon/budgie-daemon.p/meson-generated_menus.c.o src/daemon/budgie-daemon.p/meson-generated_osd.c.o src/daemon/budgie-daemon.p/meson-generated_settings.c.o src/daemon/budgie-daemon.p/meson-generated_tabswitcher.c.o src/daemon/budgie-daemon.p/meson-generated_xdgdirtracker_dbus.c.o -Wl,--as-needed -Wl,--no-undefined -Wl,--whole-archive -Wl,--start-group src/daemon/libbudgie-daemon-resources.a -Wl,--no-whole-archive '-Wl,-rpath,$ORIGIN/../lib:$ORIGIN/../plugin/panel:$ORIGIN/../theme' -Wl,-rpath-link,/build/source/build/src/lib -Wl,-rpath-link,/build/source/build/src/plugin/panel -Wl,-rpath-link,/build/source/build/src/theme src/lib/libbudgie-private.so.0.0.0 src/plugin/panel/libbudgie-plugin.so.0.0.0 src/appsys/libappsys.a src/config/libconfig.a src/theme/libbudgietheme.so.0.0.0 src/libsession/libsession.a /nix/store/fizdaxxmkzxa39r8c95jpsl268wiva2q-libcanberra-0.30/lib/libcanberra.so /nix/store/fizdaxxmkzxa39r8c95jpsl268wiva2q-libcanberra-0.30/lib/libcanberra-gtk3.so /nix/store/iz714yn348np8a3i5ljmwziwsi8p41a6-gtk+3-3.24.43/lib/libgtk-3.so /nix/store/iz714yn348np8a3i5ljmwziwsi8p41a6-gtk+3-3.24.43/lib/libgdk-3.so /nix/store/sn6h5xiavl6lxnipx2drhi4r7c3x8d8q-pango-1.52.2/lib/libpangocairo-1.0.so /nix/store/sn6h5xiavl6lxnipx2drhi4r7c3x8d8q-pango-1.52.2/lib/libpango-1.0.so /nix/store/z4gc4b4118y5p9fwy02nzhivfwyxhxxj-harfbuzz-9.0.0/lib/libharfbuzz.so /nix/store/mwp4vhjddys87nb2d71n866d3jvkf9gn-at-spi2-core-2.52.0/lib/libatk-1.0.so /nix/store/jpa6i63siv75vvwm91h12zhnn4hsrpn6-cairo-1.18.0/lib/libcairo-gobject.so /nix/store/jpa6i63siv75vvwm91h12zhnn4hsrpn6-cairo-1.18.0/lib/libcairo.so /nix/store/mpjqa2ncfxj0568wypz9wcbgj80s5qww-gdk-pixbuf-2.42.12/lib/libgdk_pixbuf-2.0.so /nix/store/7lr9qdizm42pf6clysg7syrky0si8aab-glib-2.80.4/lib/libgio-2.0.so /nix/store/7lr9qdizm42pf6clysg7syrky0si8aab-glib-2.80.4/lib/libgobject-2.0.so /nix/store/7lr9qdizm42pf6clysg7syrky0si8aab-glib-2.80.4/lib/libglib-2.0.so -L/nix/store/iz714yn348np8a3i5ljmwziwsi8p41a6-gtk+3-3.24.43/lib -L/nix/store/mwp4vhjddys87nb2d71n866d3jvkf9gn-at-spi2-core-2.52.0/lib -L/nix/store/7lr9qdizm42pf6clysg7syrky0si8aab-glib-2.80.4/lib -L/nix/store/jpa6i63siv75vvwm91h12zhnn4hsrpn6-cairo-1.18.0/lib -L/nix/store/mpjqa2ncfxj0568wypz9wcbgj80s5qww-gdk-pixbuf-2.42.12/lib -L/nix/store/sn6h5xiavl6lxnipx2drhi4r7c3x8d8q-pango-1.52.2/lib -L/nix/store/z4gc4b4118y5p9fwy02nzhivfwyxhxxj-harfbuzz-9.0.0/lib -L/nix/store/fizdaxxmkzxa39r8c95jpsl268wiva2q-libcanberra-0.30/lib -lX11 -lz -L/nix/store/iz714yn348np8a3i5ljmwziwsi8p41a6-gtk+3-3.24.43/lib -L/nix/store/mwp4vhjddys87nb2d71n866d3jvkf9gn-at-spi2-core-2.52.0/lib -L/nix/store/7lr9qdizm42pf6clysg7syrky0si8aab-glib-2.80.4/lib -L/nix/store/jpa6i63siv75vvwm91h12zhnn4hsrpn6-cairo-1.18.0/lib -L/nix/store/mpjqa2ncfxj0568wypz9wcbgj80s5qww-gdk-pixbuf-2.42.12/lib -L/nix/store/sn6h5xiavl6lxnipx2drhi4r7c3x8d8q-pango-1.52.2/lib -L/nix/store/z4gc4b4118y5p9fwy02nzhivfwyxhxxj-harfbuzz-9.0.0/lib -lz -L/nix/store/iz714yn348np8a3i5ljmwziwsi8p41a6-gtk+3-3.24.43/lib -L/nix/store/7lr9qdizm42pf6clysg7syrky0si8aab-glib-2.80.4/lib -L/nix/store/jpa6i63siv75vvwm91h12zhnn4hsrpn6-cairo-1.18.0/lib -L/nix/store/mpjqa2ncfxj0568wypz9wcbgj80s5qww-gdk-pixbuf-2.42.12/lib -L/nix/store/sn6h5xiavl6lxnipx2drhi4r7c3x8d8q-pango-1.52.2/lib -L/nix/store/z4gc4b4118y5p9fwy02nzhivfwyxhxxj-harfbuzz-9.0.0/lib -lz /nix/store/0f1qr4ldfq3ly76xvl0msnn9va2wbfwd-libnotify-0.8.3/lib/libnotify.so /nix/store/p5xhfvyvq6lrdg5smv2zgl4pywgwfzmf-libwnck-43.0/lib/libwnck-3.so -L/nix/store/iz714yn348np8a3i5ljmwziwsi8p41a6-gtk+3-3.24.43/lib -L/nix/store/mwp4vhjddys87nb2d71n866d3jvkf9gn-at-spi2-core-2.52.0/lib -L/nix/store/7lr9qdizm42pf6clysg7syrky0si8aab-glib-2.80.4/lib -L/nix/store/jpa6i63siv75vvwm91h12zhnn4hsrpn6-cairo-1.18.0/lib -L/nix/store/mpjqa2ncfxj0568wypz9wcbgj80s5qww-gdk-pixbuf-2.42.12/lib -L/nix/store/sn6h5xiavl6lxnipx2drhi4r7c3x8d8q-pango-1.52.2/lib -L/nix/store/z4gc4b4118y5p9fwy02nzhivfwyxhxxj-harfbuzz-9.0.0/lib -L/nix/store/p5xhfvyvq6lrdg5smv2zgl4pywgwfzmf-libwnck-43.0/lib -lz /nix/store/h1nzbg8rd2b40k9fy8ka93jizg8y83dy-libxfce4windowing-4.19.4/lib/libxfce4windowing-0.so -L/nix/store/iz714yn348np8a3i5ljmwziwsi8p41a6-gtk+3-3.24.43/lib -L/nix/store/mwp4vhjddys87nb2d71n866d3jvkf9gn-at-spi2-core-2.52.0/lib -L/nix/store/7lr9qdizm42pf6clysg7syrky0si8aab-glib-2.80.4/lib -L/nix/store/jpa6i63siv75vvwm91h12zhnn4hsrpn6-cairo-1.18.0/lib -L/nix/store/mpjqa2ncfxj0568wypz9wcbgj80s5qww-gdk-pixbuf-2.42.12/lib -L/nix/store/sn6h5xiavl6lxnipx2drhi4r7c3x8d8q-pango-1.52.2/lib -L/nix/store/z4gc4b4118y5p9fwy02nzhivfwyxhxxj-harfbuzz-9.0.0/lib -L/nix/store/h1nzbg8rd2b40k9fy8ka93jizg8y83dy-libxfce4windowing-4.19.4/lib -lz /nix/store/spvydpgks7q4p5r3ppqbfvgm4lgwszlc-gstreamer-1.24.3/lib/libgstreamer-1.0.so /nix/store/wsg4815rb8rnqlclynhnnk88gnvr4dhy-libpeas-1.36.0/lib/libpeas-1.0.so -Wl,--export-dynamic /nix/store/7lr9qdizm42pf6clysg7syrky0si8aab-glib-2.80.4/lib/libgmodule-2.0.so -pthread /nix/store/x8jlvh7h31ymzjm58cw98cw185482mb7-gobject-introspection-1.80.1/lib/libgirepository-1.0.so -L/nix/store/iz714yn348np8a3i5ljmwziwsi8p41a6-gtk+3-3.24.43/lib -L/nix/store/mwp4vhjddys87nb2d71n866d3jvkf9gn-at-spi2-core-2.52.0/lib -L/nix/store/7lr9qdizm42pf6clysg7syrky0si8aab-glib-2.80.4/lib -L/nix/store/jpa6i63siv75vvwm91h12zhnn4hsrpn6-cairo-1.18.0/lib -L/nix/store/mpjqa2ncfxj0568wypz9wcbgj80s5qww-gdk-pixbuf-2.42.12/lib -L/nix/store/sn6h5xiavl6lxnipx2drhi4r7c3x8d8q-pango-1.52.2/lib -L/nix/store/z4gc4b4118y5p9fwy02nzhivfwyxhxxj-harfbuzz-9.0.0/lib -lz -L/nix/store/iz714yn348np8a3i5ljmwziwsi8p41a6-gtk+3-3.24.43/lib -L/nix/store/7lr9qdizm42pf6clysg7syrky0si8aab-glib-2.80.4/lib -L/nix/store/jpa6i63siv75vvwm91h12zhnn4hsrpn6-cairo-1.18.0/lib -L/nix/store/mpjqa2ncfxj0568wypz9wcbgj80s5qww-gdk-pixbuf-2.42.12/lib -L/nix/store/sn6h5xiavl6lxnipx2drhi4r7c3x8d8q-pango-1.52.2/lib -L/nix/store/z4gc4b4118y5p9fwy02nzhivfwyxhxxj-harfbuzz-9.0.0/lib -lz -L/nix/store/iz714yn348np8a3i5ljmwziwsi8p41a6-gtk+3-3.24.43/lib -L/nix/store/mwp4vhjddys87nb2d71n866d3jvkf9gn-at-spi2-core-2.52.0/lib -L/nix/store/7lr9qdizm42pf6clysg7syrky0si8aab-glib-2.80.4/lib -L/nix/store/jpa6i63siv75vvwm91h12zhnn4hsrpn6-cairo-1.18.0/lib -L/nix/store/mpjqa2ncfxj0568wypz9wcbgj80s5qww-gdk-pixbuf-2.42.12/lib -L/nix/store/sn6h5xiavl6lxnipx2drhi4r7c3x8d8q-pango-1.52.2/lib -L/nix/store/z4gc4b4118y5p9fwy02nzhivfwyxhxxj-harfbuzz-9.0.0/lib -L/nix/store/p5xhfvyvq6lrdg5smv2zgl4pywgwfzmf-libwnck-43.0/lib -lz -Wl,--end-group
/nix/store/x7yyxvwy1f9hlx72rzrgx069jyf7hxwr-binutils-2.42/bin/ld: src/daemon/budgie-daemon.p/meson-generated_tabswitcher.c.o: in function `_budgie_tab_switcher_window_set_window_as_activated_budgie_tab_switcher_widget_window_activated':
tabswitcher.c:(.text+0x74f): undefined reference to `xfw_window_x11_get_xid'
/nix/store/x7yyxvwy1f9hlx72rzrgx069jyf7hxwr-binutils-2.42/bin/ld: src/daemon/budgie-daemon.p/meson-generated_tabswitcher.c.o: in function `budgie_tab_switcher_widget_construct':
tabswitcher.c:(.text+0xcb0): undefined reference to `xfw_window_x11_get_xid'
/nix/store/x7yyxvwy1f9hlx72rzrgx069jyf7hxwr-binutils-2.42/bin/ld: src/daemon/budgie-daemon.p/meson-generated_tabswitcher.c.o: in function `budgie_tab_switcher_window_focus_item':
tabswitcher.c:(.text+0x2152): undefined reference to `xfw_window_x11_get_xid'
collect2: error: ld returned 1 exit status

Full log: https://gist.github.com/bobby285271/f7320b024938e5c1440b0e7d25b5fc2e

Budgie version

10.9.2

Operating System

NixOS (using custom checkout)

Steps to reproduce the issue

  1. Build budgie-desktop with libxfce4windowing 4.19.4

Actual result

FTBFS.

Expected result

Builds.

Additional information

No response

fossfreedom commented 2 months ago

Hmm ... https://gitlab.xfce.org/xfce/libxfce4windowing/-/blob/main/meson_options.txt?ref_type=heads

Is libxfce4windowing definitely being built with x11 support?

bobby285271 commented 2 months ago

Ooooops, my fault, Thanks!

(We have -Dauto_features=enabled in our meson build template, but we are still building libxfce4windowing with autotools and it silently disabled x11 due to missing libdisplay-info, I should have review their configure.ac before posting :joy:)