BuddyForms / BuddyForms-WooCommerce-Form-Elements

This Plugin adds a new section to the BuddyForms Form Builder with all WooCommerce fields to create Product creation forms for the frontend
GNU General Public License v2.0
3 stars 3 forks source link

Hide fields for Advanced section aren't working #61

Closed njota08 closed 5 years ago

njota08 commented 5 years ago

Steps to reproduce

  1. Click on BuddyForms
  2. Click on Add New or select a product post type previously created
  3. Select a WC Simple Product post type template
  4. Select the WooCommerce tab
  5. Click on the "Advanced" tab
  6. In the fields "Hide Purchase Notes", "Hide Menu Orders" and "Hide Enable Reviews" mark its corresponding checkbox to hide it and fill the proper fields.
  7. Save and Publish your form
  8. Click on Preview Form
  9. Navigate to the "Advanced" tab

Expected result: The fields you hid should not appear on the tab. And as an enhancement, if the three options are marked to be hidden, the "Advanced" tab should not be displayed.

Actual result: All the fields are visible in the "Advanced" tab.

See screenshots below:

image

image

njota08 commented 5 years ago

@gfirem @marin250189

While testing this I noticed the following:

  1. If I want to hide the "Purchase Note" or the "Menu Order" by checking its checkboxes, it will do it on the Preview Form.
  2. If I mark the third checkbox to hide the "Enable Reviews", in the Preview form is being displayed.
  3. If I mark the three checkboxes to hide all the options on the Advanced tab, the entire tab is hidden.

So, there's an odd behavior with the 3rd checkbox in my opinion.

I can't mark this issue as fixed if this is not behaving as expected.

marin250189 commented 5 years ago

This issue was solved

njota08 commented 5 years ago

The behavior is the same as the last time I tested this bug. The 3rd option is not being hidden even if I mark the checkbox. The only way to hide the field is by checking the 3 checkboxes and the entire tab disappear (That's ok).

njota08 commented 5 years ago

Fixed, tested and closed.