BuddyWing / BuddyWing.DefaultCombat

The default combat routine included with BuddyWing, the bot for SWTOR
Apache License 2.0
12 stars 12 forks source link

Bug Discipline CanNotBeDetermined Bodyguard #20

Closed Wired203 closed 8 years ago

Wired203 commented 8 years ago

[DefaultCombat] Level: 65 [DefaultCombat] Class: BountyHunter [DefaultCombat] Advanced Class: Mercenary [DefaultCombat] Discipline: CanNotBeDetermined

Should be Bodyguard

Also noted were Commando -> Combat Medic Sentinel -> Watchman

aevitas commented 8 years ago

Can be fixed in similar fashion to #2 . We'll need the unique ability this discipline has again. Perhaps @Markeeen will be our hero once more?

Wired203 commented 8 years ago

Alltrueist noted the Commando and Sentinel so I'll ping him on those, I'm sure later tonight I can check for Merc no problem.

alltrueist commented 8 years ago

Can you just set it so that it detects if we have the unique level 10 ability that each discipline gets? That seems to be the simplest way to create a safety valve for when the specs aren't loading.

aevitas commented 8 years ago

@alltrueist Yes, that's how we've been handling those individual cases of where the node ID for abilities changed between patches, we basically check if (AdvancedClass == AdvancedClass.Whatever && AbilityManager.HasSpell("Unique Level 10 spell")) return Discipline.Something; to patch up those individual cases.

We'll need the unique combination for this specific case to implement that though.

CryoGenesisX commented 8 years ago

Here is the full list:

INFO: http://dulfy.net/2014/10/13/swtor-disciplines-calculator-swtor_miner/?link=dGEAAAEKAwECAAAAAAAAAAAA

WATCH OUT FOR DOUBLE LVL 10 ABILITIES!!! (-1 to -4)

--REPUBLIC--

Class, Advanced, Discipline, Level 10 ability, DPS/TANK/HEAL
Trooper, Commando, Combat Medic, Advanced Medical Probe, HEAL
Trooper, Commando, Gunnery, Grav Round, DPS
Trooper, Commando, Assault Specialist, Incendiary Round, DPS
Trooper, Vanguard, Shield Specialist, Riot Gas, TANK
Trooper, Vanguard, Plasmatech, Shockstrike, DPS
Trooper, Vanguard, Tactics, Gut, DPS
Smuggler, Scoundrel, Sawbones, Underworld Medicine, HEAL
Smuggler, Scoundrel, Scrapper, Sucker Punch, DPS
Smuggler, Scoundrel, Ruffian, Brutal Shots, DPS
Smuggler, Gunslinger, Sharpshooter, Aimed Shot, DPS
Smuggler, Gunslinger, Saboteur, Sabotage Charge, DPS
Smuggler, Gunslinger, Dirty Fighting, Shrap Bomb, DPS
Jedi Consular, Shadow (Shadow (Jedi Shadow)), Kinetic Combat, Kinetic Ward, TANK
Jedi Consular, Shadow (Jedi Shadow), Infiltration, Shadow Technique, DPS
-1 Jedi Consular, Shadow (Jedi Shadow), Serenity, Force in Balance, DPS
Jedi Consular, Sage (Jedi Sage), Seer, Deliverence, HEAL
Jedi Consular, Sage (Jedi Sage), Telekinetics, Telekinetic Wave, DPS
-1 Jedi Consular, Sage (Jedi Sage), Balance, Force in balance, DPS
Jedi Knight, Guardian (Jedi Guardian), Defense, Warding Strike, TANK
Jedi Knight, Guardian (Jedi Guardian), Vigilance, Plasma Brand, DPS
-2 Jedi Knight, Guardian (Jedi Guardian), Focus, Focused Burst, DPS
Jedi Knight, Sentinel (Jedi Sentinel), Watchman, Force Melt, DPS
Jedi Knight, Sentinel (Jedi Sentinel), Combat, Ataru Form, DPS
-2 Jedi Knight, Sentinel (Jedi Sentinel), Concentration, Focused Burst, DPS

--EMPIRE--

Bounty Hunter, Mercenary, Bodyguard, Healing Scan, HEAL
Bounty Hunter, Mercenary, Arsenal, Tracer Missile, DPS
Bounty Hunter, Mercenary, Innovative Ordnance, Incendiary Missile, DPS
Bounty Hunter, Powertech, Shield Tech, Oil Slick, TANK
Bounty Hunter, Powertech, Pyrotech, Flaming Fist, DPS
Bounty Hunter, Powertech, Advanced Prototype, Retractable Blade, DPS
Imperial Agent, Operative, Medicine, Kolto Injection, HEAL
Imperial Agent, Operative, Concealment, Laceration, DPS
Imperial Agent, Operative, Lethality, Corrosive Assault, DPS
Imperial Agent, Sniper, Markmanship, Ambush, DPS
Imperial Agent, Sniper, Engineering, Explosive Probe, DPS
Imperial Agent, Sniper, Virulence, Corrosive Grenade, DPS
Sith Inquisitor, Assassin (Sith Assassin), Darkness, Dark Ward, TANK
Sith Inquisitor, Assassin (Sith Assassin), Deception, Surging Charge, DPS
-3 Sith Inquisitor, Assassin (Sith Assassin), Hatred, Death Field, DPS
Sith Inquisitor, Sorcerer (Sith Sorcerer), Corruption, Dark Infusion, HEAL
Sith Inquisitor, Sorcerer (Sith Sorcerer), Lightning, Chain Lightning, DPS
-3 Sith Inquisitor, Sorcerer (Sith Sorcerer), Madness, Death Field, DPS
Sith Warrior, Juggernaut (Sith Juggernaut), Immortal, Aegis Assault, TANK
Sith Warrior, Juggernaut (Sith Juggernaut), Vengeance, Shatter, DPS
-4 Sith Warrior, Juggernaut (Sith Juggernaut), Rage, Raging Burst, DPS
Sith Warrior, Marauder (Sith Marauder), Annihilation, Force Rend, DPS
Sith Warrior, Marauder (Sith Marauder), Carnage, Ataru Form, DPS
-4 Sith Warrior, Marauder (Sith Marauder), Fury, Raging Burst, DPS
aevitas commented 8 years ago

We'll have this one fixed in the next release for BW - it's a core issue however, so I've created this issue as a progress tracking mirror in the BW repo: https://github.com/BosslandGmbH/BuddyWing/issues/27